From: Dave Chinner <david@fromorbit.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed
Date: Tue, 30 Aug 2016 09:40:44 +1000 [thread overview]
Message-ID: <20160829234044.GS19025@dastard> (raw)
In-Reply-To: <20160829232615.GA29648@redhat.com>
On Mon, Aug 29, 2016 at 06:26:15PM -0500, Bill O'Donnell wrote:
> On Tue, Aug 30, 2016 at 09:12:06AM +1000, Dave Chinner wrote:
> > On Mon, Aug 29, 2016 at 08:40:12AM -0500, Bill O'Donnell wrote:
> > > Commits b20b6c2 and 29647c8 modified xfs_quota for use on
> > > non-XFS filesystems. One modification in fs_initialise_mounts
> > > (paths.c) resulted in an xfstest fail (xfs/261), due to foreign
> > > fs paths entering the fs table.
> >
> > What's the failure? I'm not seeing it here on any of my test
> > machines...
>
> On my box, there are a few ext4 mounts, and test xfs/261
> populates the fs table with those paths.
I have ext2 and ext3 mounts on these machines as well, and they
don't throw any errors.
> So when xfs_quota commands
> in 261 are executed, a "foreign filesystem" message is thrown.
What is the output that is causing the failure? When someone
asks you to describe the error that is occurring, please quote the
/exact error/ that is occurring - describing it via paraphrasing
does not tell anything useful about the error as I cannot correlate
that description to the code that is throwing it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-29 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 13:40 [PATCH] xfsprogs: don't populate fs table with foreign fs paths unless foreign_allowed Bill O'Donnell
2016-08-29 15:13 ` Darrick J. Wong
2016-08-29 15:43 ` Bill O'Donnell
2016-08-29 23:16 ` Dave Chinner
2016-08-29 23:28 ` Bill O'Donnell
2016-08-29 23:12 ` Dave Chinner
2016-08-29 23:26 ` Bill O'Donnell
2016-08-29 23:40 ` Dave Chinner [this message]
2016-08-29 23:47 ` Bill O'Donnell
2016-08-30 0:25 ` Dave Chinner
2016-08-30 0:53 ` Bill O'Donnell
2016-09-01 22:07 ` Bill O'Donnell
2016-09-02 21:22 ` [PATCH v2] xfsprogs: (xfs_quota) foreign fs path handling changes Bill O'Donnell
2016-09-02 22:57 ` Eric Sandeen
2016-09-02 23:10 ` Bill O'Donnell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829234044.GS19025@dastard \
--to=david@fromorbit.com \
--cc=billodo@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox