From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: BUG: Internal error xfs_trans_cancel at line 984 of file fs/xfs/xfs_trans.c
Date: Fri, 2 Sep 2016 07:46:17 +1000 [thread overview]
Message-ID: <20160901214617.GE30056@dastard> (raw)
In-Reply-To: <20160901103955.GD27776@eguan.usersys.redhat.com>
On Thu, Sep 01, 2016 at 06:39:55PM +0800, Eryu Guan wrote:
> On Mon, Aug 29, 2016 at 06:37:54PM +0800, Eryu Guan wrote:
> > Hi,
> >
> > I've hit an XFS internal error then filesystem shutdown with 4.8-rc3
> > kernel but not with 4.8-rc2
> >
> [snip]
> >
> > So it's likely a regression introduced in 4.8-rc3, and my bisect test
> > pointed to commit 0af32fb468b4 ("xfs: fix bogus space reservation in
> > xfs_iomap_write_allocate").
>
> This might be buried in the report, I've bisected this down to
>
> commit 0af32fb468b4a4434dd759d68611763658650b59
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Aug 17 08:30:28 2016 +1000
>
> xfs: fix bogus space reservation in xfs_iomap_write_allocate
*nod*. I did notice that - it's what I based my previous "this is
what I think it causing the warning" email on. i.e. we're dirtying a
AGF/AGFL to update the freelist, then finding we don't have space in
the AG for the data allocation, then we ENOSPC and cancel a dirty
transaction.
I'm not going to back this change out right now, because it does fix
other, much easier to hit issues. I think it has probably uncovered
another "off-by-one" corner case in the "can we use the AG"
calculations, so when I get a chance I'll look through the code
and see what I can find. A faster reproducer would make that a lot
easier, so if you manage to find one, I woul dbe very helpful.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-09-01 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 10:37 BUG: Internal error xfs_trans_cancel at line 984 of file fs/xfs/xfs_trans.c Eryu Guan
2016-08-30 2:39 ` Dave Chinner
2016-08-30 14:48 ` Eryu Guan
2016-09-29 7:54 ` Eryu Guan
2016-09-29 8:00 ` Eryu Guan
2016-08-31 8:56 ` Eryu Guan
2016-09-01 10:39 ` Eryu Guan
2016-09-01 21:46 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901214617.GE30056@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).