From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-xfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: undo block reservation correctly in xfs_trans_reserve()
Date: Wed, 7 Sep 2016 08:35:33 +1000 [thread overview]
Message-ID: <20160906223533.GL30056@dastard> (raw)
In-Reply-To: <20160906115045.GG2462@eguan.usersys.redhat.com>
On Tue, Sep 06, 2016 at 07:50:45PM +0800, Eryu Guan wrote:
> On Tue, Sep 06, 2016 at 06:48:28PM +1000, Dave Chinner wrote:
> > On Tue, Sep 06, 2016 at 04:03:59PM +0800, Eryu Guan wrote:
> > > Fixes: 0d485ada404b ("xfs: use generic percpu counters for free block counter")
> >
> > I really don't like this sort of "annotation". It wrongly implies
> > the commit was broken (it wasn't) and there's no scope for stating
> > the problem context. i.e. that the problem is a minor regression in
> > a rarely travelled corner case that is unlikely to affect production
> > machines in any significant way. It's better to describe things with
> > all the relevant context:
> >
> > "This is a regression introduced in commit ... and only occurs when
> > .... "
>
> Makes sense, will do so.
>
> >
> > > Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> >
> > Not @redhat?
>
> I thought that I'm employed by Red Hat as a QE not a filesystem
> developer, all filesystem patches I send reflect my own opinions not my
> employer's, so all silly mistakes I made in the patches are under my
> personal email too :)
Copyright assignments rarely work like that. It's a big grey area,
though, so I think you should check with your legal department as to
what you should use here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-09-06 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 8:03 [PATCH] xfs: undo block reservation correctly in xfs_trans_reserve() Eryu Guan
2016-09-06 8:48 ` Dave Chinner
2016-09-06 11:50 ` Eryu Guan
2016-09-06 22:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906223533.GL30056@dastard \
--to=david@fromorbit.com \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).