From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, xfs@oss.sgi.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs/279: filter scsi debug device correctly
Date: Thu, 8 Sep 2016 08:47:47 +1000 [thread overview]
Message-ID: <20160907224747.GH22388@dastard> (raw)
In-Reply-To: <1473053427-15498-1-git-send-email-eguan@redhat.com>
On Mon, Sep 05, 2016 at 01:30:27PM +0800, Eryu Guan wrote:
> This test assumes scsi debug device is "/dev/sd." when doing the
> filter, but that isn't always true, I've seen failure like
>
> -mkfs with opts: DEVICE
> +mkfs with opts: DEVICEl
Yeah, I can see how that would occur when you have enough scsi
devices to go to multiple device characters (e.g. /dev/sdal).
> So use $SCSI_DEBUG_DEV to match the correct scsi debug device name.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-09-07 22:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 5:30 [PATCH] xfs/279: filter scsi debug device correctly Eryu Guan
2016-09-07 22:47 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907224747.GH22388@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).