Re: [PATCH] fstests: make some xfs project quota tests generic

Eryu Guan
2016-09-23T01:58:17Z

On Thu, Sep 22, 2016 at 05:51:03PM -0500, Eric Sandeen wrote:
> This patch makes some xfs project quota tests generic,
> so that there is at least some coverage on ext4 for this
> (semi-)new feature.
>
> It requires bleeding edge xfsprogs, so that xfs_quota and
> xfs_io's chproj command can operate on "foreign" filesystems,
> and requires relatively new e2fsprogs to enable the project
> quota feature on-disk.
>
> The mechanism for enabling project quota on ext4 is a bit
> arcane, but hopefully I've encapsulated it reasonably well here.
>
> Changes:
>
> * look for "project" feature in _require_prjquota
> * look for accounting not enforcement (-P) in _require_prjquota
> * add a _scratch_enable_pquota to turn on project quota feature
> * s/pquota/quota/ in _qmount_option for ext4
> * add helper to test for xfs_io chproj on foreign filesystems
> * switch from block to inode quota in xfs/133 because empty
> ext4 dirs consume one block
> * cosmetic/generic changes for mkfs, require tests, etc.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Eryu, would you like to do the move-to-generic/ since you'll need
> to renumber them anyway? :)

Yeah, sure, I can do that :)

>
> Note -
> This requires the previous patch I sent to the fstests list,
>
> [PATCH 2/3 V2] modify xfs/ quota tests to work on generic filesystems

Thanks!

Eryu