From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:41429 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030388AbcIXTmg (ORCPT ); Sat, 24 Sep 2016 15:42:36 -0400 Date: Sat, 24 Sep 2016 12:42:34 -0700 From: Christoph Hellwig Subject: Re: [PATCH 58/71] xfs: garbage collect old cowextsz reservations Message-ID: <20160924194234.GA1878@infradead.org> References: <147216791538.867.12413509832420924168.stgit@birch.djwong.org> <147216829394.867.16281333542262043955.stgit@birch.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147216829394.867.16281333542262043955.stgit@birch.djwong.org> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: david@fromorbit.com, linux-xfs@vger.kernel.org, xfs@oss.sgi.com On Thu, Aug 25, 2016 at 04:38:14PM -0700, Darrick J. Wong wrote: > Trim CoW reservations made on behalf of a cowextsz hint if they get too > old or we run low on quota, so long as we don't have dirty data awaiting > writeback or directio operations in progress. FYI, at least in your latest tree we only ever seem to set xfs_inode_set_cowblocks_tag in xfs_swap_extents, so this effectively isn't used during normal fs usage. Also any reason we can't use the same infrastructure as our normal speculative preallocation here?