From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:49532 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934881AbcIYOb5 (ORCPT ); Sun, 25 Sep 2016 10:31:57 -0400 Date: Sun, 25 Sep 2016 07:31:55 -0700 From: Christoph Hellwig Subject: Re: [PATCH] libxcmd: fix counting of xfs entries in fs_table_insert Message-ID: <20160925143155.GB29268@infradead.org> References: <1474798162-25960-1-git-send-email-eguan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474798162-25960-1-git-send-email-eguan@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eryu Guan Cc: linux-xfs@vger.kernel.org, billodo@redhat.com, xfs@oss.sgi.com On Sun, Sep 25, 2016 at 06:09:22PM +0800, Eryu Guan wrote: > Commit bb80e3d6cd04 ("libxcmd: populate fs table with xfs entries > first, foreign entries last") adds a new counter "xfs_fs_count" and > increases the counter when inserting an XFS entry. > > But it missed a counter when fs_count is zero (inserting the first > path) and the entry has no FS_FOREIGN bit set, i.e. the first XFS > entry doesn't increase xfs_fs_count. > > This results in args_command() mess and infinite loop in xfs/244 > when testing v4 XFS (xfs/244 notrun on v5 XFS, but this bug still > reproduces on v5 XFS). e.g. > > mkfs -t xfs -f /dev/sda5 > mount -o pquota /dev/sda5 /mnt/xfs > mkdir /mnt/xfs/project > touch /mnt/xfs/project/testfile > xfs_quota -x -c "project -s -p /mnt/xfs/project/testfile 1" /dev/sda5 > > Fix it by increasing xfs_fs_count when flags has no FS_FOREIGN bit. Looks ifne, Reviewed-by: Christoph Hellwig Can I assume you'll add the above test to xfstests?