* [PATCH] mkfs.xfs: clarify ftype defaults in manpage
@ 2016-09-16 20:48 Eric Sandeen
2016-09-19 2:16 ` Dave Chinner
2016-09-19 13:26 ` [PATCH V2] " Eric Sandeen
0 siblings, 2 replies; 5+ messages in thread
From: Eric Sandeen @ 2016-09-16 20:48 UTC (permalink / raw)
To: xfs-oss, linux-xfs; +Cc: Chris Murphy
When CRCs were made default, a few leftovers related to its
prior non-default status remained in the manpage, in the ftype
section. Clean those up.
Reported-by: Chris Murphy <chris@cmurf.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 9578c4d..033bc36 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -636,13 +636,13 @@ do not need to look up the inode to determine the inode type.
The
.I value
-is either 0 or 1, with 1 signifiying that filetype information
-will be stored in the directory structure. The default value is 0.
+is either 0 or 1, with 1 signifying that filetype information
+will be stored in the directory structure.
-When CRCs are enabled via
-.B \-m crc=1,
-the ftype functionality is always enabled. This feature can not be turned
-off for such filesystem configurations.
+When CRCs are enabled (the default), the ftype functionality is always
+enabled, and cannot be turned off. If CRCs are disabled with
+.B \-m crc=0,
+the ftype functionality is disabled by default.
.IP
.RE
.TP
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mkfs.xfs: clarify ftype defaults in manpage
2016-09-16 20:48 [PATCH] mkfs.xfs: clarify ftype defaults in manpage Eric Sandeen
@ 2016-09-19 2:16 ` Dave Chinner
2016-09-19 12:44 ` Eric Sandeen
2016-09-19 13:26 ` [PATCH V2] " Eric Sandeen
1 sibling, 1 reply; 5+ messages in thread
From: Dave Chinner @ 2016-09-19 2:16 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs, Chris Murphy, xfs-oss
On Fri, Sep 16, 2016 at 03:48:14PM -0500, Eric Sandeen wrote:
> When CRCs were made default, a few leftovers related to its
> prior non-default status remained in the manpage, in the ftype
> section. Clean those up.
>
> Reported-by: Chris Murphy <chris@cmurf.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 9578c4d..033bc36 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -636,13 +636,13 @@ do not need to look up the inode to determine the inode type.
>
> The
> .I value
> -is either 0 or 1, with 1 signifiying that filetype information
> -will be stored in the directory structure. The default value is 0.
> +is either 0 or 1, with 1 signifying that filetype information
> +will be stored in the directory structure.
>
> -When CRCs are enabled via
> -.B \-m crc=1,
> -the ftype functionality is always enabled. This feature can not be turned
> -off for such filesystem configurations.
> +When CRCs are enabled (the default), the ftype functionality is always
> +enabled, and cannot be turned off. If CRCs are disabled with
> +.B \-m crc=0,
> +the ftype functionality is disabled by default.
I think that's wrong:
$ sudo mkfs.xfs -f -m crc=0 /dev/vda
....
naming =version 2 bsize=4096 ascii-ci=0 ftype=1
^^^^^^^
i.e. ftype is enabled by default for all configurations these days.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mkfs.xfs: clarify ftype defaults in manpage
2016-09-19 2:16 ` Dave Chinner
@ 2016-09-19 12:44 ` Eric Sandeen
0 siblings, 0 replies; 5+ messages in thread
From: Eric Sandeen @ 2016-09-19 12:44 UTC (permalink / raw)
To: Dave Chinner, Eric Sandeen; +Cc: xfs-oss, linux-xfs, Chris Murphy
On 9/18/16 9:16 PM, Dave Chinner wrote:
> On Fri, Sep 16, 2016 at 03:48:14PM -0500, Eric Sandeen wrote:
>> When CRCs were made default, a few leftovers related to its
>> prior non-default status remained in the manpage, in the ftype
>> section. Clean those up.
>>
>> Reported-by: Chris Murphy <chris@cmurf.com>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
>> index 9578c4d..033bc36 100644
>> --- a/man/man8/mkfs.xfs.8
>> +++ b/man/man8/mkfs.xfs.8
>> @@ -636,13 +636,13 @@ do not need to look up the inode to determine the inode type.
>>
>> The
>> .I value
>> -is either 0 or 1, with 1 signifiying that filetype information
>> -will be stored in the directory structure. The default value is 0.
>> +is either 0 or 1, with 1 signifying that filetype information
>> +will be stored in the directory structure.
>>
>> -When CRCs are enabled via
>> -.B \-m crc=1,
>> -the ftype functionality is always enabled. This feature can not be turned
>> -off for such filesystem configurations.
>> +When CRCs are enabled (the default), the ftype functionality is always
>> +enabled, and cannot be turned off. If CRCs are disabled with
>> +.B \-m crc=0,
>> +the ftype functionality is disabled by default.
>
> I think that's wrong:
>
> $ sudo mkfs.xfs -f -m crc=0 /dev/vda
> ....
> naming =version 2 bsize=4096 ascii-ci=0 ftype=1
> ^^^^^^^
>
> i.e. ftype is enabled by default for all configurations these days.
Oh hell, you're right. I'll resend. In retrospect that was probably
a mistake, but it is what it is :)
-Eric
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH V2] mkfs.xfs: clarify ftype defaults in manpage
2016-09-16 20:48 [PATCH] mkfs.xfs: clarify ftype defaults in manpage Eric Sandeen
2016-09-19 2:16 ` Dave Chinner
@ 2016-09-19 13:26 ` Eric Sandeen
2016-09-25 14:35 ` Christoph Hellwig
1 sibling, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2016-09-19 13:26 UTC (permalink / raw)
To: xfs
When CRCs were made default, a few leftovers related to its
prior non-default status remained in the manpage, in the ftype
section. Clean those up, stating the correct default for this
feature.
Reported-by: Chris Murphy <chris@cmurf.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: reflect reality regarding defaults, sorry about that.
diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
index 9578c4d..c44b3bd 100644
--- a/man/man8/mkfs.xfs.8
+++ b/man/man8/mkfs.xfs.8
@@ -636,13 +636,11 @@ do not need to look up the inode to determine the inode type.
The
.I value
-is either 0 or 1, with 1 signifiying that filetype information
-will be stored in the directory structure. The default value is 0.
+is either 0 or 1, with 1 signifying that filetype information
+will be stored in the directory structure. The default value is 1.
-When CRCs are enabled via
-.B \-m crc=1,
-the ftype functionality is always enabled. This feature can not be turned
-off for such filesystem configurations.
+When CRCs are enabled (the default), the ftype functionality is always
+enabled, and cannot be turned off.
.IP
.RE
.TP
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-25 14:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 20:48 [PATCH] mkfs.xfs: clarify ftype defaults in manpage Eric Sandeen
2016-09-19 2:16 ` Dave Chinner
2016-09-19 12:44 ` Eric Sandeen
2016-09-19 13:26 ` [PATCH V2] " Eric Sandeen
2016-09-25 14:35 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).