From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: rewrite the COW writeback mapping code
Date: Tue, 27 Sep 2016 20:48:50 +0200 [thread overview]
Message-ID: <20160927184850.GA22830@lst.de> (raw)
In-Reply-To: <20160926213557.GD14092@birch.djwong.org>
> if (xfs_is_reflink_inode(XFS_I(inode))) {
>
> since we don't have to care about COW mappings unless the inode also has
> shared extents. The code you got this from seems to have this bug too;
> I'll just fix this when I push the patch onto my stack.
Indeed. I felt the check to be a bit odd, but for some reason didn't
follow up on it.
next prev parent reply other threads:[~2016-09-27 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 15:19 only do a single COW fork lookup in writeback Christoph Hellwig
2016-09-24 15:19 ` [PATCH 1/2] xfs: kill xfs_reflink_is_cow_pending Christoph Hellwig
2016-09-26 21:08 ` Darrick J. Wong
2016-09-24 15:19 ` [PATCH 2/2] xfs: rewrite the COW writeback mapping code Christoph Hellwig
2016-09-26 21:35 ` Darrick J. Wong
2016-09-27 18:48 ` Christoph Hellwig [this message]
2016-09-25 3:47 ` only do a single COW fork lookup in writeback Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927184850.GA22830@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).