From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Brian Foster <bfoster@redhat.com>,
fstests@vger.kernel.org, xfs@oss.sgi.com,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3] tests/generic: test xfs log recovery metadata LSN ordering
Date: Wed, 28 Sep 2016 09:44:15 +1000 [thread overview]
Message-ID: <20160927234415.GB9806@dastard> (raw)
In-Reply-To: <20160927133730.GP27776@eguan.usersys.redhat.com>
On Tue, Sep 27, 2016 at 09:37:30PM +0800, Eryu Guan wrote:
> On Tue, Sep 27, 2016 at 09:12:49AM -0400, Brian Foster wrote:
> > On Mon, Aug 15, 2016 at 08:56:26AM -0400, Brian Foster wrote:
> > > XFS had a bug that lead to a possible out-of-order log recovery
> > > situation (e.g., replay a stale modification from the log over more
> > > recent metadata in destination buffer). This resulted in false
> > > corruption reports during log recovery and thus mount failure.
> > >
> > > This condition is caused by system crash or filesystem shutdown shortly
> > > after a successful log recovery. Add a test to run a combined workload,
> > > fs shutdown and log recovery loop known to reproduce the problem on
> > > affected kernels.
> > >
> > > Signed-off-by: Brian Foster <bfoster@redhat.com>
> > > ---
> > >
> >
> > ping
>
> It's pending in my stage tree, because it crashes current upstream
> kernel, and Dave wants the fixes go upstream first, so the test won't
> crash the test machine and interrupt the test.
>
> I noticed the fixes are in xfs tree for-next branch, I think we're ready
> to include this test in next fstests update.
Yup, it's good to go.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-09-27 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 12:56 [PATCH v3] tests/generic: test xfs log recovery metadata LSN ordering Brian Foster
2016-09-27 13:12 ` Brian Foster
2016-09-27 13:37 ` Eryu Guan
2016-09-27 23:44 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927234415.GB9806@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).