From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:47804 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753281AbcI0XoV (ORCPT ); Tue, 27 Sep 2016 19:44:21 -0400 Date: Wed, 28 Sep 2016 09:44:15 +1000 From: Dave Chinner Subject: Re: [PATCH v3] tests/generic: test xfs log recovery metadata LSN ordering Message-ID: <20160927234415.GB9806@dastard> References: <1471265786-24970-1-git-send-email-bfoster@redhat.com> <20160927131249.GA38187@bfoster.bfoster> <20160927133730.GP27776@eguan.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160927133730.GP27776@eguan.usersys.redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eryu Guan Cc: Brian Foster , fstests@vger.kernel.org, xfs@oss.sgi.com, linux-xfs@vger.kernel.org On Tue, Sep 27, 2016 at 09:37:30PM +0800, Eryu Guan wrote: > On Tue, Sep 27, 2016 at 09:12:49AM -0400, Brian Foster wrote: > > On Mon, Aug 15, 2016 at 08:56:26AM -0400, Brian Foster wrote: > > > XFS had a bug that lead to a possible out-of-order log recovery > > > situation (e.g., replay a stale modification from the log over more > > > recent metadata in destination buffer). This resulted in false > > > corruption reports during log recovery and thus mount failure. > > > > > > This condition is caused by system crash or filesystem shutdown shortly > > > after a successful log recovery. Add a test to run a combined workload, > > > fs shutdown and log recovery loop known to reproduce the problem on > > > affected kernels. > > > > > > Signed-off-by: Brian Foster > > > --- > > > > > > > ping > > It's pending in my stage tree, because it crashes current upstream > kernel, and Dave wants the fixes go upstream first, so the test won't > crash the test machine and interrupt the test. > > I noticed the fixes are in xfs tree for-next branch, I think we're ready > to include this test in next fstests update. Yup, it's good to go. Cheers, Dave. -- Dave Chinner david@fromorbit.com