From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] libxfs: remove unused libxfs_iget arg
Date: Tue, 27 Sep 2016 19:09:48 -0700 [thread overview]
Message-ID: <20160928020948.GB4428@infradead.org> (raw)
In-Reply-To: <355fec5f-f7ef-8472-c71b-7bfa9d9ab8bd@redhat.com>
On Tue, Sep 27, 2016 at 01:10:28PM -0500, Eric Sandeen wrote:
> libxfs_iget() is always called with bno == 0.
> Which is probably a good thing, because it then passes
> bno to xfs_iread as iget_flags!
>
> So remove the libxfs_iget arg, and explicitly pass
> 0 to xfs_iread for flags.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> (or should we just rename/re-type bno to a flags arg?)
Killing it seems fine to me. Any argument not actually used is just
asking for bugs like the one you just fixed.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-09-28 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 18:10 [PATCH] libxfs: remove unused libxfs_iget arg Eric Sandeen
2016-09-28 2:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928020948.GB4428@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).