public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: eguan@redhat.com, linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 3/3] xfs/{207,327}: fsxattr no longer has the reflink flag
Date: Thu, 29 Sep 2016 16:27:55 +1000	[thread overview]
Message-ID: <20160929062755.GM9806@dastard> (raw)
In-Reply-To: <147511612047.12284.3645173774395982911.stgit@birch.djwong.org>

On Wed, Sep 28, 2016 at 07:28:40PM -0700, Darrick J. Wong wrote:
> The FS_XFLAG_REFLINK flag was removed from struct fsxattr prior to
> the inclusion of reflink in XFS, so remove it from the test outputs.
> Note that the inode flag still exists; it's simply not presented
> to userspace any more.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Fixes the failures I've seen

Reviewed-by: Dave Chinner <dchinner@redhat.com>

> ---
>  tests/xfs/207.out |    4 ++--
>  tests/xfs/327.out |    6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> 
> diff --git a/tests/xfs/207.out b/tests/xfs/207.out
> index 434b8d9..f6dc17d 100644
> --- a/tests/xfs/207.out
> +++ b/tests/xfs/207.out
> @@ -11,8 +11,8 @@ Check extsz and cowextsz settings on 1Mbyte file
>  [0] SCRATCH_MNT/test-207/file2
>  [1048576] SCRATCH_MNT/test-207/file2
>  Set cowextsize and check flag
> -fsxattr.xflags = 0x20000 [----------------C]
> +fsxattr.xflags = 0x10000 [---------------C]
>  [1048576] SCRATCH_MNT/test-207/file3
>  Unset cowextsize and check flag
> -fsxattr.xflags = 0x0 [-----------------]
> +fsxattr.xflags = 0x0 [----------------]
>  [0] SCRATCH_MNT/test-207/file3
> diff --git a/tests/xfs/327.out b/tests/xfs/327.out
> index c88d623..5b3cba2 100644
> --- a/tests/xfs/327.out
> +++ b/tests/xfs/327.out
> @@ -3,11 +3,11 @@ Format filesystem
>  Create files
>  Check files
>  8fa14cdd754f91cc6554c9e71929cce7  SCRATCH_MNT/file.0
> -[reflink] SCRATCH_MNT/file.0 
> +[] SCRATCH_MNT/file.0 
>  8fa14cdd754f91cc6554c9e71929cce7  SCRATCH_MNT/file.64
> -[reflink] SCRATCH_MNT/file.64 
> +[] SCRATCH_MNT/file.64 
>  8fa14cdd754f91cc6554c9e71929cce7  SCRATCH_MNT/file.128
> -[reflink] SCRATCH_MNT/file.128 
> +[] SCRATCH_MNT/file.128 
>  CoW all files
>  Repair filesystem
>  Check files again
> 
> 

-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2016-09-29  6:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29  2:28 [PATCH 1/3] xfs/122: decrease the log update done item sizes Darrick J. Wong
2016-09-29  2:28 ` [PATCH 2/3] xfs/130: don't modify files after failed mount Darrick J. Wong
2016-09-29  6:27   ` Dave Chinner
2016-09-29  2:28 ` [PATCH 3/3] xfs/{207,327}: fsxattr no longer has the reflink flag Darrick J. Wong
2016-09-29  6:27   ` Dave Chinner [this message]
2016-09-29  6:26 ` [PATCH 1/3] xfs/122: decrease the log update done item sizes Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929062755.GM9806@dastard \
    --to=david@fromorbit.com \
    --cc=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox