From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tytso@mit.edu" <tytso@mit.edu>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"bfoster@redhat.com" <bfoster@redhat.com>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
"hch@infradead.org" <hch@infradead.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 3/3] block: implement (some of) fallocate for block devices
Date: Thu, 29 Sep 2016 13:35:46 -0700 [thread overview]
Message-ID: <20160929203545.GF14092@birch.djwong.org> (raw)
In-Reply-To: <423d057c-d2cc-9039-d8ee-c6526be3ae46@sandisk.com>
On Thu, Sep 29, 2016 at 01:08:57PM -0700, Bart Van Assche wrote:
> On 09/28/2016 07:19 PM, Darrick J. Wong wrote:
> >After much discussion, it seems that the fallocate feature flag
> >FALLOC_FL_ZERO_RANGE maps nicely to SCSI WRITE SAME; and the feature
> >FALLOC_FL_PUNCH_HOLE maps nicely to the devices that have been
> >whitelisted for zeroing SCSI UNMAP. Punch still requires that
> >FALLOC_FL_KEEP_SIZE is set. A length that goes past the end of the
> >device will be clamped to the device size if KEEP_SIZE is set; or will
> >return -EINVAL if not. Both start and length must be aligned to the
> >device's logical block size.
> >
> >Since the semantics of fallocate are fairly well established already,
> >wire up the two pieces. The other fallocate variants (collapse range,
> >insert range, and allocate blocks) are not supported.
>
> For the FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE
> case, it's probably safer not to try to send a discard to block devices that
> do not support discard in order not to hit block driver bugs. But that's
> something we can still discuss later. Hence:
I'll just change it to check the queue flags and post a new revision.
At this point I might as well repost the whole thing to reflect the
reviewed-bys.
--D
> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-09-29 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 0:39 [PATCH v10 0/3] fallocate for block devices Darrick J. Wong
2016-09-29 0:39 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-09-29 1:16 ` Bart Van Assche
2016-09-29 5:56 ` Hannes Reinecke
2016-09-29 0:39 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-09-29 5:56 ` Hannes Reinecke
2016-09-29 0:39 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
2016-09-29 1:42 ` Bart Van Assche
2016-09-29 2:09 ` Darrick J. Wong
2016-09-29 2:19 ` [PATCH v2 " Darrick J. Wong
2016-09-29 20:08 ` Bart Van Assche
2016-09-29 20:35 ` Darrick J. Wong [this message]
2016-09-29 5:57 ` [PATCH " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929203545.GF14092@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=bfoster@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).