From: Eryu Guan <eguan@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fstests: fix failures caused by striped device
Date: Fri, 7 Oct 2016 20:29:49 +0800 [thread overview]
Message-ID: <20161007122949.GK27776@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1475336934-19105-1-git-send-email-zlang@redhat.com>
On Sat, Oct 01, 2016 at 11:48:54PM +0800, Zorro Lang wrote:
> There're some failures if scratch_dev is a striped device:
> 1. generic/094 and generic/225 fiemap_tester fails.
> 2. generic/347 need -f to force usage of a misaligned device
> 3. xfs/010, xfs/013, xfs/042 and xfs/109 print "Warning: AG size
> is a multiple of stripe width", break the golden image
> 4. xfs/029 print more "extended-header"
>
> Only XFS can reproduce these failures, so this patch:
> 1. use "-d sunit=0,swidth=0,noalign" options for generic/094,
> generic/225 and xfs/029.
I'm not sure about this, is it possible to update fiemap_tester.c to
deal with stripes or just _notrun in such cases? I'm waiting for great
ideas too :)
> 2. print the error output of mkfs.xfs to /dev/null forr xfs/010,
> xfs/013, xfs/042 and xfs/109
This looks good to me.
> 3. add -f option for generic/347
And this breaks test on ext4, not all mkfs.<fstype> support -f option.
Thanks,
Eryu
prev parent reply other threads:[~2016-10-07 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 15:48 [PATCH] fstests: fix failures caused by striped device Zorro Lang
2016-10-07 12:29 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007122949.GK27776@eguan.usersys.redhat.com \
--to=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).