linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs/122: remove dead code
Date: Sat, 8 Oct 2016 10:45:14 -0700	[thread overview]
Message-ID: <20161008174514.GB5619@birch.djwong.org> (raw)
In-Reply-To: <1475916836-30439-1-git-send-email-eguan@redhat.com>

On Sat, Oct 08, 2016 at 04:53:56PM +0800, Eryu Guan wrote:
> Seems this hunk of dead code is used for debug purpose to inspect
> what the output looks like after _attribute_filter. Just remove it.

Heh.  Barf.  Ooops. :)

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>  tests/xfs/122 | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/tests/xfs/122 b/tests/xfs/122
> index 330d3ac..f39ceba 100755
> --- a/tests/xfs/122
> +++ b/tests/xfs/122
> @@ -196,10 +196,6 @@ echo 'int main(int argc, char *argv[]) {' >>$cprog
>  #
>  cat /usr/include/xfs/xfs*.h | indent |\
>  _attribute_filter |\
> -egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' > /tmp/barf
> -
> -cat /usr/include/xfs/xfs*.h | indent |\
> -_attribute_filter |\
>  egrep '(} *xfs_.*_t|^struct xfs_[a-z0-9_]*$)' |\
>  egrep -v -f $tmp.ignore |\
>  sed -e 's/^.*}[[:space:]]*//g' -e 's/;.*$//g' -e 's/_t, /_t\n/g' |\
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2016-10-08 17:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08  8:53 [PATCH] xfs/122: remove dead code Eryu Guan
2016-10-08 17:45 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161008174514.GB5619@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).