From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 6/7] xfs: fix error initialization
Date: Mon, 10 Oct 2016 16:36:53 +1100 [thread overview]
Message-ID: <20161010053653.GU9806@dastard> (raw)
In-Reply-To: <05debeab-15ec-2b6b-1704-e6d396242cfe@sandeen.net>
On Sat, Oct 08, 2016 at 10:55:58AM -0500, Eric Sandeen wrote:
> On 10/7/16 6:07 PM, Darrick J. Wong wrote:
> > Eric Sandeen reported a gcc complaint about uninitialized error
> > variables, so fix that.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reported-by: Eric Sandeen <sandeen@redhat.com>
> > ---
> > fs/xfs/xfs_reflink.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> > diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
> > index 220d263..5965e94 100644
> > --- a/fs/xfs/xfs_reflink.c
> > +++ b/fs/xfs/xfs_reflink.c
> > @@ -1437,7 +1437,7 @@ xfs_reflink_dirty_extents(
> > xfs_off_t flen;
> > struct xfs_bmbt_irec map[2];
> > int nmaps;
> > - int error;
> > + int error = 0;
> >
> > while (end - fbno > 0) {
>
> If we should never get here w/ end <= fbno, then maybe an ASSERT is
> in order.
That should be the case - the fallocate infrastructure should be
ensuring len > 0 and we don't overflow. Followup patch, if you think
it necessary, Darrick?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-10-10 5:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 23:07 [PATCH 0/7] xfs: reflink fixes Darrick J. Wong
2016-10-07 23:07 ` [PATCH 1/7] xfs: rework refcount cow recovery error handling Darrick J. Wong
2016-10-10 5:37 ` Dave Chinner
2016-10-10 6:10 ` Darrick J. Wong
2016-10-10 6:11 ` [PATCH v2 " Darrick J. Wong
2016-10-10 10:21 ` Christoph Hellwig
2016-10-10 18:21 ` Darrick J. Wong
2016-10-10 20:25 ` Dave Chinner
2016-10-10 21:46 ` Darrick J. Wong
2016-10-07 23:07 ` [PATCH 2/7] xfs: check inode reflink flag before calling reflink functions Darrick J. Wong
2016-10-10 5:24 ` Dave Chinner
2016-10-10 10:18 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 3/7] xfs: reduce stack usage of _reflink_clear_inode_flag Darrick J. Wong
2016-10-10 5:25 ` Dave Chinner
2016-10-10 10:17 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 4/7] xfs: remove isize check from unshare operation Darrick J. Wong
2016-10-10 5:26 ` Dave Chinner
2016-10-10 10:21 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 5/7] xfs: fix label inaccuracies Darrick J. Wong
2016-10-10 5:27 ` Dave Chinner
2016-10-10 10:22 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 6/7] xfs: fix error initialization Darrick J. Wong
2016-10-08 15:55 ` Eric Sandeen
2016-10-10 5:36 ` Dave Chinner [this message]
2016-10-10 10:23 ` Christoph Hellwig
2016-10-07 23:08 ` [PATCH 7/7] xfs: clear reflink flag if setting realtime flag Darrick J. Wong
2016-10-10 5:29 ` Dave Chinner
2016-10-10 10:24 ` Christoph Hellwig
2016-10-10 12:25 ` Dave Chinner
2016-10-10 12:45 ` Christoph Hellwig
2016-10-10 12:59 ` Dave Chinner
2016-10-10 17:18 ` Darrick J. Wong
2016-10-10 12:44 ` Brian Foster
2016-10-10 18:10 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010053653.GU9806@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).