From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, darrick.wong@oracle.com
Subject: Re: [PATCH] xfs: convert COW blocks to real blocks before unwritten extent conversion
Date: Tue, 11 Oct 2016 18:38:25 +1100 [thread overview]
Message-ID: <20161011073825.GI23194@dastard> (raw)
In-Reply-To: <1476104794-28175-1-git-send-email-hch@lst.de>
On Mon, Oct 10, 2016 at 03:06:34PM +0200, Christoph Hellwig wrote:
> We need to splice COW blocks we've completed in xfs_end_io_direct_write
> into the data fork before converting unwritten extents. Otherwise
> xfs_bmapi_write might first allocate blocks for any holes in the data
> fork, which isn't only not needed but also harmful as it might cause
> reserved block underruns in the transaction.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Committed and pushe dout to the for-next branch (commit
feac470e3642e8956ac9b7f14224e6b301b9219d). If there's no more
late-breaking, urgent fixes, then this is what I'll ask Linus to
pull tomorrow....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-10-11 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 13:06 [PATCH] xfs: convert COW blocks to real blocks before unwritten extent conversion Christoph Hellwig
2016-10-11 7:38 ` Dave Chinner [this message]
2016-10-11 18:39 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011073825.GI23194@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).