From: Cyril Hrubis <chrubis@suse.cz>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: ltp@lists.linux.it, linux-xfs@vger.kernel.org
Subject: Re: [LTP] [PATCH] m4/ltp-xfs_quota.m4: fix xfs quota check
Date: Thu, 13 Oct 2016 16:11:45 +0200 [thread overview]
Message-ID: <20161013141145.GA12204@rei.lan> (raw)
In-Reply-To: <1476150729-2128-1-git-send-email-yangx.jy@cn.fujitsu.com>
Hi!
> Current check doesn't work since xfsprogs v4.5.0.
> Undefined off64_t type leads to this issue, so we
> need to define _GNU_SOURCE to make off64_t defined.
>
> This has been broken by upstream xfsporgs-dev commmit
>
> commit cb898f157f8410a03cf5f3400baa1df9e5eecd33
> Author: Felix Janda <felix.janda@posteo.de>
> Date: Fri Feb 5 08:34:06 2016 +1100
>
> linux.h: Use off64_t instead of loff_t
That kind of looks like a bug in xfs-progs, since off64_t is not exposed
from glibc unless we enable either largefile support or define
_GNU_SOURCE. As a matter of fact the _GNU_SOURCE enables
_LARGEFILE64_SOURCE which then enables the typedef that exposes the
off64_t typedef.
So they are depending on a type that is not defined by default but since
the code has been part of at least three releases already we have to
apply the workaround for it anyway.
Patch pushed, thanks.
[CCing the XFS mailing list in case they want to do something about it]
--
Cyril Hrubis
chrubis@suse.cz
next parent reply other threads:[~2016-10-13 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1476150729-2128-1-git-send-email-yangx.jy@cn.fujitsu.com>
2016-10-13 14:11 ` Cyril Hrubis [this message]
2016-10-13 19:46 ` [LTP] [PATCH] m4/ltp-xfs_quota.m4: fix xfs quota check Dave Chinner
2016-10-17 9:16 ` Cyril Hrubis
2016-10-18 0:04 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013141145.GA12204@rei.lan \
--to=chrubis@suse.cz \
--cc=linux-xfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).