From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, eguan@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] misc: fix fallocate commands that need the unshare switch
Date: Sat, 15 Oct 2016 10:03:03 -0700 [thread overview]
Message-ID: <20161015170303.GB11829@infradead.org> (raw)
In-Reply-To: <147646878237.19627.11366131824882808123.stgit@birch.djwong.org>
On Fri, Oct 14, 2016 at 11:13:02AM -0700, Darrick J. Wong wrote:
> We re-added the UNSHARE flag to fallocate, so go make sure that all
> the unshare tests actually check that the xfs_io falloc command
> supports that flag.
We'll need to improve _require_xfs_io_command to actually run the
command for this to work, otherwise this will fail if the fs supports
reflink but not unshared once xfs_io supports -u.
The poster child would be btrfs, and I would have added some output
here if btrfs support in xfstests wasn't completely broken at this
point.
Well, added Ccs and some output anyway in this case..
root@testvm:~/xfstests# mkfs.btrfs -f /dev/vdb
Btrfs v3.17
See http://btrfs.wiki.kernel.org for more information.
Turning ON incompat feature 'extref': increased hardlink limit per file
to 65536
[ 243.592803] BTRFS: device fsid 364c6d95-eaae-43c9-b6bd-139e86206519
devid 1 transid 3 /dev/vdb
fs created label (null) on /dev/vdb
nodesize 16384 leafsize 16384 sectorsize 4096 size 10.00GiB
root@testvm:~/xfstests# ./check -g quick
[ 246.101606] BTRFS info (device vdb): disk space caching is enabled
[ 246.102260] BTRFS info (device vdb): flagging fs with big metadata
feature
[ 246.106123] BTRFS info (device vdb): creating UUID tree
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 testvm 4.8.0+
MKFS_OPTIONS -- /dev/vdb
MOUNT_OPTIONS -- /dev/vdb /mnt/scratch
our local _scratch_mkfs routine ...
Error: /dev/vdb is mounted
check: failed to mkfs $SCRATCH_DEV using specified options
Passed all 0 tests
next prev parent reply other threads:[~2016-10-15 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 18:12 [PATCH 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-14 18:12 ` [PATCH 1/3] xfs: set the refcount btree cowflag when setting up cow Darrick J. Wong
2016-10-15 16:57 ` Christoph Hellwig
2016-10-14 18:13 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-15 17:03 ` Christoph Hellwig [this message]
2016-10-16 6:18 ` Christoph Hellwig
2016-10-17 21:57 ` Darrick J. Wong
2016-10-14 18:13 ` [PATCH 3/3] misc: fix more xfs_db usage Darrick J. Wong
2016-10-15 17:03 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-10-17 22:09 [PATCH v2 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-17 22:09 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-18 5:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015170303.GB11829@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).