From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: remove redundant assignment of ifp
Date: Mon, 17 Oct 2016 10:35:00 -0700 [thread overview]
Message-ID: <20161017173500.GH1120@birch.djwong.org> (raw)
In-Reply-To: <20161017173240.26542-1-colin.king@canonical.com>
On Mon, Oct 17, 2016 at 06:32:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove redundant ifp = ifp statement, it does nothing. Found with
> static analysis by CoverityScan.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..0283b7e 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
> ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
> &eidx, &got, &new);
>
> - ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
> + ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
> ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
> (uint)sizeof(xfs_bmbt_rec_t)));
> ASSERT(del->br_blockcount > 0);
> --
> 2.9.3
>
prev parent reply other threads:[~2016-10-17 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 17:32 [PATCH] xfs: remove redundant assignment of ifp Colin King
2016-10-17 17:35 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017173500.GH1120@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=colin.king@canonical.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).