* [PATCH] xfs: remove redundant assignment of ifp
@ 2016-10-17 17:32 Colin King
2016-10-17 17:35 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-10-17 17:32 UTC (permalink / raw)
To: Dave Chinner, linux-xfs, Darrick J . Wong, Brian Foster,
Eric Sandeen
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove redundant ifp = ifp statement, it does nothing. Found with
static analysis by CoverityScan.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/xfs/libxfs/xfs_bmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index c27344c..0283b7e 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
&eidx, &got, &new);
- ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
+ ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
(uint)sizeof(xfs_bmbt_rec_t)));
ASSERT(del->br_blockcount > 0);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: remove redundant assignment of ifp
2016-10-17 17:32 [PATCH] xfs: remove redundant assignment of ifp Colin King
@ 2016-10-17 17:35 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2016-10-17 17:35 UTC (permalink / raw)
To: Colin King
Cc: Dave Chinner, linux-xfs, Brian Foster, Eric Sandeen, linux-kernel
On Mon, Oct 17, 2016 at 06:32:40PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove redundant ifp = ifp statement, it does nothing. Found with
> static analysis by CoverityScan.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..0283b7e 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
> ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
> &eidx, &got, &new);
>
> - ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
> + ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
> ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
> (uint)sizeof(xfs_bmbt_rec_t)));
> ASSERT(del->br_blockcount > 0);
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-17 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 17:32 [PATCH] xfs: remove redundant assignment of ifp Colin King
2016-10-17 17:35 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).