From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc
Date: Mon, 17 Oct 2016 14:36:21 -0700 [thread overview]
Message-ID: <20161017213621.GB7786@birch.djwong.org> (raw)
In-Reply-To: <3f9689e1-3e1a-c874-f6ae-88ac40f9cde1@redhat.com>
On Mon, Oct 17, 2016 at 08:54:25AM -0500, Eric Sandeen wrote:
> The commit:
>
> f65306ea xfs: map an inode's offset to an exact physical block
>
> added a pointless error0: target; remove it.
>
> Addresses-Coverity-Id: 1373865
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index c27344c..861cf8d 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -3974,9 +3974,6 @@ xfs_bmap_remap_alloc(
> * allocating, so skip that check by pretending to be freeing.
> */
> error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING);
> - if (error)
> - goto error0;
> -error0:
> xfs_perag_put(args.pag);
> if (error)
> trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-10-17 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 13:54 [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc Eric Sandeen
2016-10-17 15:03 ` Bill O'Donnell
2016-10-17 21:36 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017213621.GB7786@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).