From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:32434 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934166AbcJQVg0 (ORCPT ); Mon, 17 Oct 2016 17:36:26 -0400 Date: Mon, 17 Oct 2016 14:36:21 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs: remove pointless error goto in xfs_bmap_remap_alloc Message-ID: <20161017213621.GB7786@birch.djwong.org> References: <3f9689e1-3e1a-c874-f6ae-88ac40f9cde1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f9689e1-3e1a-c874-f6ae-88ac40f9cde1@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs On Mon, Oct 17, 2016 at 08:54:25AM -0500, Eric Sandeen wrote: > The commit: > > f65306ea xfs: map an inode's offset to an exact physical block > > added a pointless error0: target; remove it. > > Addresses-Coverity-Id: 1373865 > Signed-off-by: Eric Sandeen Reviewed-by: Darrick J. Wong > --- > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > index c27344c..861cf8d 100644 > --- a/fs/xfs/libxfs/xfs_bmap.c > +++ b/fs/xfs/libxfs/xfs_bmap.c > @@ -3974,9 +3974,6 @@ xfs_bmap_remap_alloc( > * allocating, so skip that check by pretending to be freeing. > */ > error = xfs_alloc_fix_freelist(&args, XFS_ALLOC_FLAG_FREEING); > - if (error) > - goto error0; > -error0: > xfs_perag_put(args.pag); > if (error) > trace_xfs_bmap_remap_alloc_error(ap->ip, error, _RET_IP_); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html