From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: david@fromorbit.com, eguan@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] misc: fix fallocate commands that need the unshare switch
Date: Mon, 17 Oct 2016 14:57:16 -0700 [thread overview]
Message-ID: <20161017215716.GA20337@birch.djwong.org> (raw)
In-Reply-To: <20161016061837.GA12614@infradead.org>
On Sat, Oct 15, 2016 at 11:18:37PM -0700, Christoph Hellwig wrote:
> On Sat, Oct 15, 2016 at 10:03:03AM -0700, Christoph Hellwig wrote:
> > The poster child would be btrfs, and I would have added some output
> > here if btrfs support in xfstests wasn't completely broken at this
> > point.
> >
> > Well, added Ccs and some output anyway in this case..
>
> Turns out the btrfs failure was my stupidity, sorry.
>
> I can reproduce the issue I was going to originally show (which was
> actually pointed out by Eric for a different fallocate flag check
> I wanted to add), here is the diff of the output files when running
> generic/156 on btrfs with your patch:
Somehow it totally escaped my notice that I could just do:
_require_xfs_io_command "funshare"
and that would suffice for excluding things like btrfs. Will
rework.
--D
>
> --- tests/generic/156.out 2016-03-29 13:59:30.411720622 +0000
> +++ /root/xfstests/results//generic/156.out.bad 2016-10-16 06:15:27.118776421 +0000
> @@ -2,8 +2,13 @@
> Create the original file blocks
> Create the reflink copies
> funshare part of a file
> +fallocate: Operation not supported
> funshare some of the copies
> +fallocate: Operation not supported
> +fallocate: Operation not supported
> funshare the rest of the files
> +fallocate: Operation not supported
> +fallocate: Operation not supported
> Rewrite the original file
> free blocks after reflinking is in range
> free blocks after nocow'ing some copies is in range
>
> So what we really need an enhanced falloc tester that checks that
> the tested subcommand is actually implemented on the given file system.
> (And we already need something like that for -k on NFS)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-17 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 18:12 [PATCH 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-14 18:12 ` [PATCH 1/3] xfs: set the refcount btree cowflag when setting up cow Darrick J. Wong
2016-10-15 16:57 ` Christoph Hellwig
2016-10-14 18:13 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-15 17:03 ` Christoph Hellwig
2016-10-16 6:18 ` Christoph Hellwig
2016-10-17 21:57 ` Darrick J. Wong [this message]
2016-10-14 18:13 ` [PATCH 3/3] misc: fix more xfs_db usage Darrick J. Wong
2016-10-15 17:03 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-10-17 22:09 [PATCH v2 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-17 22:09 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-18 5:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017215716.GA20337@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).