* [PATCH] mkfs.xfs: fix static-lib build
@ 2016-10-17 19:13 Theodore Ts'o
2016-10-17 22:40 ` Dave Chinner
0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2016-10-17 19:13 UTC (permalink / raw)
To: linux-xfs; +Cc: Dmitry Monakhov, Theodore Ts'o
From: Dmitry Monakhov <dmonakhov@openvz.org>
Order is important for static libraries, libblkid depends on libuuid.
We have to pass libuuid after libblkid, otherwise it fails like this:
#make mkfs.xfs
[LD] mkfs.xfs
/bin/bash ../libtool --quiet --tag=CC --mode=link gcc -o mkfs.xfs -static -L/devel/xfstests-bld.git/bld/lib -static-libtool-libs maxtrres.o proto.o xfs_mkfs.o ../libxfs/libxfs.la ../libxcmd/libxcmd.la -luuid -lrt -lpthread -lblkid
/devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `set_uuid':
/devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:132: undefined reference to `uuid_is_null'
/devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:133: undefined reference to `uuid_unparse'
/devel/xfstests-bld.git/bld/lib/libblkid.a(probe.o): In function `get_ext2_info':
/devel/xfstests-bld.git/e2fsprogs-libs/lib/blkid/probe.c:156: undefined reference to `uuid_is_null'
collect2: error: ld returned 1 exit status
../include/buildrules:45: recipe for target 'mkfs.xfs' failed
make: *** [mkfs.xfs] Error 1
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
mkfs/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/Makefile b/mkfs/Makefile
index 170e3c1..c13b903 100644
--- a/mkfs/Makefile
+++ b/mkfs/Makefile
@@ -10,7 +10,7 @@ LTCOMMAND = mkfs.xfs
HFILES =
CFILES = maxtrres.c proto.c xfs_mkfs.c
-LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBUUID) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID)
+LLDLIBS += $(LIBXFS) $(LIBXCMD) $(LIBRT) $(LIBPTHREAD) $(LIBBLKID) $(LIBUUID)
LTDEPENDENCIES += $(LIBXFS) $(LIBXCMD)
LLDFLAGS = -static-libtool-libs
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mkfs.xfs: fix static-lib build
2016-10-17 19:13 [PATCH] mkfs.xfs: fix static-lib build Theodore Ts'o
@ 2016-10-17 22:40 ` Dave Chinner
2016-10-18 2:14 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2016-10-17 22:40 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-xfs, Dmitry Monakhov
On Mon, Oct 17, 2016 at 03:13:27PM -0400, Theodore Ts'o wrote:
> From: Dmitry Monakhov <dmonakhov@openvz.org>
>
> Order is important for static libraries, libblkid depends on libuuid.
> We have to pass libuuid after libblkid, otherwise it fails like this:
$ glo -n 1 mkfs/Makefile
9e1c66ca9cee mkfs: fix library ordering
$ git describe --contains 9e1c66ca9cee
v4.8.0-rc1~49
$
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mkfs.xfs: fix static-lib build
2016-10-17 22:40 ` Dave Chinner
@ 2016-10-18 2:14 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-10-18 2:14 UTC (permalink / raw)
To: Dave Chinner; +Cc: linux-xfs, Dmitry Monakhov
On Tue, Oct 18, 2016 at 09:40:42AM +1100, Dave Chinner wrote:
> On Mon, Oct 17, 2016 at 03:13:27PM -0400, Theodore Ts'o wrote:
> > From: Dmitry Monakhov <dmonakhov@openvz.org>
> >
> > Order is important for static libraries, libblkid depends on libuuid.
> > We have to pass libuuid after libblkid, otherwise it fails like this:
>
> $ glo -n 1 mkfs/Makefile
> 9e1c66ca9cee mkfs: fix library ordering
> $ git describe --contains 9e1c66ca9cee
> v4.8.0-rc1~49
> $
My bad, I still have a repo which is tracking the xfsprogs git tree on
oss.sgi.com instead of git.kernel.org.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-18 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 19:13 [PATCH] mkfs.xfs: fix static-lib build Theodore Ts'o
2016-10-17 22:40 ` Dave Chinner
2016-10-18 2:14 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).