From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: unset MS_ACTIVE if mount fails
Date: Mon, 17 Oct 2016 22:24:13 -0700 [thread overview]
Message-ID: <20161018052413.GA32065@infradead.org> (raw)
In-Reply-To: <20161018011051.GB20337@birch.djwong.org>
On Mon, Oct 17, 2016 at 06:10:51PM -0700, Darrick J. Wong wrote:
> As part of the inode block map intent log item recovery process, we had
> to set the IRECOVERY flag to prevent an unlinked inode from being
> truncated during the first iput call. This required us to set MS_ACTIVE
> so that iput puts the inode on the lru instead of immediately evicting
> the inode.
>
> Unfortunately, if the mount fails later on, the inodes that have been
> loaded (root dir and realtime) actually need to be evicted since we're
> aborting the mount. If we don't clear MS_ACTIVE in the failure step,
> those inodes are not evicted and therefore leak. The leak was found
> by running xfs/130 and rmmoding xfs immediately after the test.
Actually that was an item I wanted to sort out about reflink before
we got it merged..
Can you explain why we even added the MS_ACTIVE flag? Is it
to fool iput_final into keeping the inode on the lru? I'd really
prefer if we could just do it in our own ->drop_inode call then
instead of messing with MS_ACTIVE.
next prev parent reply other threads:[~2016-10-18 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 1:10 [PATCH] xfs: unset MS_ACTIVE if mount fails Darrick J. Wong
2016-10-18 5:24 ` Christoph Hellwig [this message]
2016-10-18 5:38 ` Darrick J. Wong
2016-10-18 6:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018052413.GA32065@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).