From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: david@fromorbit.com, linux-xfs@vger.kernel.org,
hch@infradead.org, Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org
Subject: Re: [PATCH 3/3] misc: fix more xfs_db open-coding instances
Date: Thu, 20 Oct 2016 20:21:34 -0700 [thread overview]
Message-ID: <20161021032134.GC5257@birch.djwong.org> (raw)
In-Reply-To: <20161020144459.GL27776@eguan.usersys.redhat.com>
On Thu, Oct 20, 2016 at 10:44:59PM +0800, Eryu Guan wrote:
> On Mon, Oct 17, 2016 at 03:09:34PM -0700, Darrick J. Wong wrote:
> > Convert some more cases of 'xfs_db $SCRATCH_DEV' to _scratch_xfs_db
> > that were left out of the initial cleanup patch.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > ---
> > tests/xfs/004 | 2 +-
> > tests/xfs/007 | 8 ++++----
> > tests/xfs/021 | 4 ++--
> > tests/xfs/044 | 2 +-
> > tests/xfs/052 | 2 +-
> > tests/xfs/116 | 4 ++--
> > tests/xfs/136 | 6 +++---
> > tests/xfs/199 | 6 +++---
> > tests/xfs/278 | 16 ++++++++--------
> > tests/xfs/291 | 2 +-
> > tests/xfs/307 | 20 ++++++++++----------
> > tests/xfs/308 | 20 ++++++++++----------
> > 12 files changed, 46 insertions(+), 46 deletions(-)
> >
> >
> > diff --git a/tests/xfs/004 b/tests/xfs/004
> > index 59b8997..09da2fe 100755
> > --- a/tests/xfs/004
> > +++ b/tests/xfs/004
> > @@ -74,7 +74,7 @@ eval `$DF_PROG $SCRATCH_MNT 2>&1 \
> > echo "df gave: blocks=$blocks used=$used avail=$avail" >>$seqres.full
> > echo "blocksize from mkfs is '$dbsize'" >>$seqres.full
> >
> > -xfs_db -r -c "freesp -s" $SCRATCH_DEV >$tmp.xfs_db
> > +_scratch_xfs_db -r -c "freesp -s" >$tmp.xfs_db
> > echo "xfs_db for $SCRATCH_DEV" >>$seqres.full
> > cat $tmp.xfs_db >>$seqres.full
> >
> > diff --git a/tests/xfs/007 b/tests/xfs/007
> > index f2e3584..eb2c9b3 100755
> > --- a/tests/xfs/007
> > +++ b/tests/xfs/007
> > @@ -68,8 +68,8 @@ do_test()
> > grep $qino_2 | awk '{print $NF}'`
> >
> > echo "*** Usage before quotarm ***"
> > - xfs_db -c "inode $QINO_1" -c "p core.nblocks" $SCRATCH_DEV
> > - xfs_db -c "inode $QINO_2" -c "p core.nblocks" $SCRATCH_DEV
> > + _scratch_xfs_db -c "inode $QINO_1" -c "p core.nblocks"
> > + _scratch_xfs_db -c "inode $QINO_2" -c "p core.nblocks"
>
> I removed the trailing whitespace at commit time added by above lines
> and some other lines in this patch.
Ok, thank you. :)
--D
>
> Thanks,
> Eryu
prev parent reply other threads:[~2016-10-21 3:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 22:09 [PATCH v2 0/3] xfstests: fix tests for rmap/reflink Darrick J. Wong
2016-10-17 22:09 ` [PATCH 1/3] xfs: set the refcount btree cowflag when setting up cow Darrick J. Wong
2016-10-17 22:09 ` [PATCH 2/3] misc: fix fallocate commands that need the unshare switch Darrick J. Wong
2016-10-18 5:19 ` Christoph Hellwig
2016-10-17 22:09 ` [PATCH 3/3] misc: fix more xfs_db open-coding instances Darrick J. Wong
2016-10-20 14:44 ` Eryu Guan
2016-10-21 3:21 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021032134.GC5257@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).