From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: fix up inode cowblocks tracking tracepoints
Date: Fri, 21 Oct 2016 17:52:11 -0700 [thread overview]
Message-ID: <20161022005211.GA5256@birch.djwong.org> (raw)
In-Reply-To: <1477070533-59327-2-git-send-email-bfoster@redhat.com>
On Fri, Oct 21, 2016 at 01:22:11PM -0400, Brian Foster wrote:
> These calls are still using the eofblocks tracepoints. The cowblocks
> equivalents are already defined, we just aren't actually calling them.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Good catch!
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_icache.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 14796b7..f295049 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -1656,9 +1656,9 @@ void
> xfs_inode_set_cowblocks_tag(
> xfs_inode_t *ip)
> {
> - trace_xfs_inode_set_eofblocks_tag(ip);
> + trace_xfs_inode_set_cowblocks_tag(ip);
> return __xfs_inode_set_eofblocks_tag(ip, xfs_queue_cowblocks,
> - trace_xfs_perag_set_eofblocks,
> + trace_xfs_perag_set_cowblocks,
> XFS_ICI_COWBLOCKS_TAG);
> }
>
> @@ -1666,7 +1666,7 @@ void
> xfs_inode_clear_cowblocks_tag(
> xfs_inode_t *ip)
> {
> - trace_xfs_inode_clear_eofblocks_tag(ip);
> + trace_xfs_inode_clear_cowblocks_tag(ip);
> return __xfs_inode_clear_eofblocks_tag(ip,
> - trace_xfs_perag_clear_eofblocks, XFS_ICI_COWBLOCKS_TAG);
> + trace_xfs_perag_clear_cowblocks, XFS_ICI_COWBLOCKS_TAG);
> }
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-22 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 17:22 [PATCH 0/3] xfs: a few reflink cowblocks fixes Brian Foster
2016-10-21 17:22 ` [PATCH 1/3] xfs: fix up inode cowblocks tracking tracepoints Brian Foster
2016-10-22 0:52 ` Darrick J. Wong [this message]
2016-10-22 8:46 ` Christoph Hellwig
2016-10-21 17:22 ` [PATCH 2/3] xfs: clear cowblocks tag when cow fork is emptied Brian Foster
2016-10-22 0:58 ` Darrick J. Wong
2016-10-22 8:47 ` Christoph Hellwig
2016-10-21 17:22 ` [PATCH 3/3] xfs: don't skip cow forks w/ delalloc blocks in cowblocks scan Brian Foster
2016-10-22 8:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161022005211.GA5256@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).