From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 17/39] xfs_io: get and set the CoW extent size hint
Date: Wed, 26 Oct 2016 12:06:20 +1100 [thread overview]
Message-ID: <20161026010620.GG23194@dastard> (raw)
In-Reply-To: <147743672316.11035.10557430267483073641.stgit@birch.djwong.org>
On Tue, Oct 25, 2016 at 04:05:23PM -0700, Darrick J. Wong wrote:
> Enable administrators to get or set the CoW extent size hint.
> Report the hint when we run stat. This also requires some
> autoconf magic to detect whether or not fsx_cowextsize exists.
....
> +++ b/include/builddefs.in
> @@ -109,6 +109,7 @@ HAVE_MNTENT = @have_mntent@
> HAVE_FLS = @have_fls@
> HAVE_FSETXATTR = @have_fsetxattr@
> HAVE_MREMAP = @have_mremap@
> +HAVE_FSXATTR_COWEXTSIZE = @have_fsxattr_cowextsize@
> ENABLE_INTERNAL_FSXATTR = @enable_internal_fsxattr@
We really need a comment here that states that
ENABLE_INTERNAL_FSXATTR=yes implies HAVE_FSXATTR_COWEXTSIZE=yes
because of the autoconf magic we do....
> diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
> index 7a847e9..45954c2 100644
> --- a/m4/package_libcdev.m4
> +++ b/m4/package_libcdev.m4
> @@ -265,3 +265,29 @@ AC_DEFUN([AC_HAVE_MREMAP],
> )
> AC_SUBST(have_mremap)
> ])
> +
> +#
> +# Check if we have a struct fsxattr with a fsx_cowextsize field.
> +# If linux/fs.h has a struct with that field, then we're ok.
> +# If we can't find fsxattr in linux/fs.h at all, the internal
> +# definitions provide it, and we're ok.
> +#
> +# The only way we won't have this is if the kernel headers don't
> +# have the field.
> +#
> +AC_DEFUN([AC_HAVE_FSXATTR_COWEXTSIZE],
> + [ AM_CONDITIONAL([INTERNAL_FSXATTR], [test "x$enable_internal_fsxattr" = xyes])
> + AM_COND_IF([INTERNAL_FSXATTR],
> + [have_fsxattr_cowextsize=yes],
Ok, so here we set the value. I think this needs a better/more
generic comment because we're going to have to repeat this
pattern in future. i.e. explain the basic construct, then as a
separate statement say "apply it to detection of the fsx_cowextsize
field".
> + [ AC_CHECK_TYPE(struct fsxattr,
> + [AC_CHECK_MEMBER(struct fsxattr.fsx_cowextsize,
> + have_fsxattr_cowextsize=yes,
> + have_fsxattr_cowextsize=no,
> + [#include <linux/fs.h>]
> + )],
> + have_fsxattr_cowextsize=yes,
> + [#include <linux/fs.h>]
> + )
> + ])
> + AC_SUBST(have_fsxattr_cowextsize)
> + ])
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-10-26 1:06 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 23:03 [PATCH v10 00/39] xfsprogs: add reflink and dedupe support Darrick J. Wong
2016-10-25 23:03 ` [PATCH 01/39] xfs: convert RUI log formats to use variable length arrays Darrick J. Wong
2016-10-26 10:21 ` Christoph Hellwig
2016-10-25 23:03 ` [PATCH 02/39] xfs_buflock: handling parsing errors more gracefully Darrick J. Wong
2016-10-26 10:22 ` Christoph Hellwig
2016-10-25 23:03 ` [PATCH 03/39] xfs: define the on-disk refcount btree format Darrick J. Wong
2016-10-26 10:23 ` Christoph Hellwig
2016-10-25 23:04 ` [PATCH 04/39] xfs: add refcount btree operations Darrick J. Wong
2016-10-26 10:23 ` Christoph Hellwig
2016-10-25 23:04 ` [PATCH 05/39] xfs: connect refcount adjust functions to upper layers Darrick J. Wong
2016-10-26 10:24 ` Christoph Hellwig
2016-10-26 18:06 ` Darrick J. Wong
2016-10-25 23:04 ` [PATCH 06/39] xfs: implement deferred bmbt map/unmap operations Darrick J. Wong
2016-10-25 23:04 ` [PATCH 07/39] xfs: introduce the CoW fork Darrick J. Wong
2016-10-26 10:25 ` Christoph Hellwig
2016-10-26 17:59 ` Darrick J. Wong
2016-10-25 23:04 ` [PATCH 08/39] xfs: create a separate cow extent size hint for the allocator Darrick J. Wong
2016-10-25 23:04 ` [PATCH 09/39] xfs_db: dump refcount btree data Darrick J. Wong
2016-10-26 10:28 ` Christoph Hellwig
2016-10-26 17:52 ` Darrick J. Wong
2016-10-25 23:04 ` [PATCH 10/39] xfs_db: add support for checking the refcount btree Darrick J. Wong
2016-10-26 0:49 ` Dave Chinner
2016-10-26 1:13 ` Darrick J. Wong
2016-10-26 3:26 ` Dave Chinner
2016-10-26 6:29 ` Darrick J. Wong
2016-10-25 23:04 ` [PATCH 11/39] xfs_db: metadump should copy the refcount btree too Darrick J. Wong
2016-10-26 10:29 ` Christoph Hellwig
2016-10-26 16:33 ` Darrick J. Wong
2016-10-25 23:04 ` [PATCH 12/39] xfs_db: deal with the CoW extent size hint Darrick J. Wong
2016-10-26 10:28 ` Christoph Hellwig
2016-10-25 23:04 ` [PATCH 13/39] xfs_db: print one array element per line Darrick J. Wong
2016-10-26 0:51 ` Dave Chinner
2016-10-26 1:13 ` Darrick J. Wong
2016-10-26 3:23 ` Dave Chinner
2016-10-26 3:34 ` Darrick J. Wong
2016-10-26 5:48 ` Dave Chinner
2016-10-25 23:05 ` [PATCH 14/39] xfs_growfs: report the presence of the reflink feature Darrick J. Wong
2016-10-26 10:31 ` Christoph Hellwig
2016-10-25 23:05 ` [PATCH 15/39] xfs_io: bmap should support querying CoW fork, shared blocks Darrick J. Wong
2016-10-25 23:05 ` [PATCH 16/39] libxfs: add configure option to override system header fsxattr Darrick J. Wong
2016-10-26 0:56 ` Dave Chinner
2016-10-26 1:16 ` Darrick J. Wong
2016-10-26 10:32 ` Christoph Hellwig
2016-10-26 19:04 ` Darrick J. Wong
2016-10-25 23:05 ` [PATCH 17/39] xfs_io: get and set the CoW extent size hint Darrick J. Wong
2016-10-26 1:06 ` Dave Chinner [this message]
2016-10-25 23:05 ` [PATCH 18/39] xfs_io: add refcount+bmap error injection types Darrick J. Wong
2016-10-26 10:33 ` Christoph Hellwig
2016-10-25 23:05 ` [PATCH 19/39] xfs_io: support injecting the 'per-AG reservation critically low' error Darrick J. Wong
2016-10-26 10:33 ` Christoph Hellwig
2016-10-25 23:05 ` [PATCH 20/39] xfs_io: provide long-format help for falloc Darrick J. Wong
2016-10-26 10:34 ` Christoph Hellwig
2016-10-26 16:37 ` Darrick J. Wong
2016-10-25 23:05 ` [PATCH 21/39] xfs_io: try to unshare copy-on-write blocks via fallocate Darrick J. Wong
2016-10-26 10:34 ` Christoph Hellwig
2016-10-25 23:05 ` [PATCH 22/39] xfs_logprint: support cowextsize reporting in log contents Darrick J. Wong
2016-10-26 10:34 ` Christoph Hellwig
2016-10-25 23:06 ` [PATCH 23/39] xfs_logprint: support refcount redo items Darrick J. Wong
2016-10-26 10:37 ` Christoph Hellwig
2016-10-26 17:31 ` Darrick J. Wong
2016-10-25 23:06 ` [PATCH 24/39] xfs_logprint: support bmap " Darrick J. Wong
2016-10-26 10:38 ` Christoph Hellwig
2016-10-25 23:06 ` [PATCH 25/39] man: document the inode cowextsize flags & fields Darrick J. Wong
2016-10-26 10:39 ` Christoph Hellwig
2016-10-26 17:20 ` Darrick J. Wong
2016-10-25 23:06 ` [PATCH 26/39] xfs_repair: fix get_agino_buf to avoid corrupting inodes Darrick J. Wong
2016-10-26 10:48 ` Christoph Hellwig
2016-10-25 23:06 ` [PATCH 27/39] xfs_repair: check the existing refcount btree Darrick J. Wong
2016-10-26 10:49 ` Christoph Hellwig
2016-10-25 23:06 ` [PATCH 28/39] xfs_repair: handle multiple owners of data blocks Darrick J. Wong
2016-10-26 10:57 ` Christoph Hellwig
2016-10-26 17:15 ` Darrick J. Wong
2016-10-26 21:15 ` Dave Chinner
2016-10-26 21:59 ` Darrick J. Wong
2016-10-25 23:06 ` [PATCH 29/39] xfs_repair: process reverse-mapping data into refcount data Darrick J. Wong
2016-10-25 23:06 ` [PATCH 30/39] xfs_repair: record reflink inode state Darrick J. Wong
2016-10-25 23:06 ` [PATCH 31/39] xfs_repair: fix inode reflink flags Darrick J. Wong
2016-10-25 23:07 ` [PATCH 32/39] xfs_repair: check the refcount btree against our observed reference counts when -n Darrick J. Wong
2016-10-25 23:07 ` [PATCH 33/39] xfs_repair: rebuild the refcount btree Darrick J. Wong
2016-10-25 23:07 ` [PATCH 34/39] xfs_repair: complain about copy-on-write leftovers Darrick J. Wong
2016-10-25 23:07 ` [PATCH 35/39] xfs_repair: check the CoW extent size hint Darrick J. Wong
2016-10-25 23:07 ` [PATCH 36/39] xfs_repair: use range query when while checking rmaps Darrick J. Wong
2016-10-25 23:07 ` [PATCH 37/39] xfs_repair: check for mergeable refcount records Darrick J. Wong
2016-10-25 23:07 ` [PATCH 38/39] xfs_repair: use thread pools to sort rmap data Darrick J. Wong
2016-10-25 23:07 ` [PATCH 39/39] mkfs.xfs: format reflink enabled filesystems Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026010620.GG23194@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).