linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
	Eryu Guan <eguan@redhat.com>,
	Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: [PATCH 6/6] xfs: don't call xfs_sb_quota_from_disk twice
Date: Mon, 7 Nov 2016 09:22:39 +1100	[thread overview]
Message-ID: <20161106222239.GO14023@dastard> (raw)
In-Reply-To: <147828433466.31793.7424646031402565530.stgit@birch.djwong.org>

On Fri, Nov 04, 2016 at 11:32:14AM -0700, Eric Sandeen wrote:
> >From ee3754254e8c186c99b6cdd4d59f741759d04acb Mon Sep 17 00:00:00 2001
> 
> kernel commit 5ef828c4
> xfs: avoid false quotacheck after unclean shutdown
> 
> made xfs_sb_from_disk() also call xfs_sb_quota_from_disk
> by default.

This is another of those confusing commit messages. It references
kernel commits, but does not make it clear that this is a fix first
applied to the userspace and is not being synced back to the kernel....

Cheers,

Dave.

-- 
Dave Chinner
david@fromorbit.com

      parent reply	other threads:[~2016-11-06 22:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 18:31 [PATCH 0/6] xfs: miscellaneous libxfs cleanups Darrick J. Wong
2016-11-04 18:31 ` [PATCH 1/6] libxfs: convert ushort to unsigned short Darrick J. Wong
2016-11-04 19:09   ` Eric Sandeen
2016-11-04 20:31     ` Darrick J. Wong
2016-11-04 18:31 ` [PATCH 2/6] libxfs: synchronize dinode_verify with userspace Darrick J. Wong
2016-11-04 19:07   ` Eric Sandeen
2016-11-04 21:03     ` Darrick J. Wong
2016-11-04 18:31 ` [PATCH 3/6] libxfs: fix whitespace problems Darrick J. Wong
2016-11-04 19:03   ` Eric Sandeen
2016-11-04 18:32 ` [PATCH 4/6] libxfs: fix xfs_attr_shortform_bytesfit declaration Darrick J. Wong
2016-11-04 19:11   ` Eric Sandeen
2016-11-04 18:32 ` [PATCH 5/6] libxfs: clean up _dir2_data_freescan Darrick J. Wong
2016-11-04 22:58   ` Eric Sandeen
2016-11-04 23:09     ` Darrick J. Wong
2016-11-04 23:20       ` Eric Sandeen
2016-11-05  0:00         ` Darrick J. Wong
2016-11-04 18:32 ` [PATCH 6/6] xfs: don't call xfs_sb_quota_from_disk twice Eric Sandeen
2016-11-04 19:12   ` Eric Sandeen
2016-11-06 22:22   ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161106222239.GO14023@dastard \
    --to=david@fromorbit.com \
    --cc=cmaiolino@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).