From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 10/16] libxfs: clean up _dir2_data_freescan
Date: Tue, 15 Nov 2016 02:19:15 -0800 [thread overview]
Message-ID: <20161115101915.GJ1607@infradead.org> (raw)
In-Reply-To: <147830454147.26713.11280885080763890502.stgit@birch.djwong.org>
On Fri, Nov 04, 2016 at 05:09:01PM -0700, Darrick J. Wong wrote:
> Refactor the implementations of xfs_dir2_data_freescan into a
> routine that takes the raw directory block parameters and
> a second function that figures out the raw parameters from the
> directory inode. This enables us to use the exact same code
> for both userspace and the kernel, since repair knows exactly
> which directory block geometry parameters it needs.
Looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-11-15 10:19 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 0:07 [PATCH v2 00/16] xfsprogs: miscellaneous libxfs cleanups Darrick J. Wong
2016-11-05 0:08 ` [PATCH 01/16] xfs_repair: fix some potential null pointer deferences Darrick J. Wong
2016-11-15 10:14 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 02/16] xfs_repair: fix bogus rmapbt record owner check Darrick J. Wong
2016-11-15 10:15 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 03/16] xfs_io: fix libxfs naming violation Darrick J. Wong
2016-11-15 10:15 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 04/16] libxfs: remove unnecessary hascrc test in btree verifiers Darrick J. Wong
2016-11-15 10:16 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 05/16] xfs: set XFS_DA_OP_OKNOENT in xfs_attr_get Eric Sandeen
2016-11-15 10:16 ` Christoph Hellwig
2016-11-15 13:41 ` Eric Sandeen
2016-11-16 5:21 ` Dave Chinner
2016-11-22 18:21 ` Darrick J. Wong
2016-11-22 18:21 ` [PATCH v2 " Darrick J. Wong
2016-11-05 0:08 ` [PATCH 06/16] libxfs: refactor btree crc verifier Darrick J. Wong
2016-11-15 10:17 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 07/16] libxfs: fix whitespace to match the kernel Darrick J. Wong
2016-11-15 10:17 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 08/16] libxfs: return bool from sb_version_hasmetauuid Darrick J. Wong
2016-11-15 10:17 ` Christoph Hellwig
2016-11-05 0:08 ` [PATCH 09/16] xfs: fix btree cursor error cleanups Brian Foster
2016-11-15 10:18 ` Christoph Hellwig
2016-11-22 18:23 ` [PATCH v2 " Darrick J. Wong
2016-11-05 0:09 ` [PATCH 10/16] libxfs: clean up _dir2_data_freescan Darrick J. Wong
2016-11-15 10:19 ` Christoph Hellwig [this message]
2016-11-05 0:09 ` [PATCH 11/16] tools: create libxfs-diff to compare libxfses Darrick J. Wong
2016-11-15 10:19 ` Christoph Hellwig
2016-11-05 0:09 ` [PATCH 12/16] libxfs: fix line lengths Darrick J. Wong
2016-11-15 10:20 ` Christoph Hellwig
2016-11-05 0:09 ` [PATCH 13/16] libxfs: synchronize dinode_verify with userspace Darrick J. Wong
2016-11-15 10:20 ` Christoph Hellwig
2016-11-05 0:09 ` [PATCH 14/16] libxfs: remove useless stuff from the kernel Darrick J. Wong
2016-11-15 10:20 ` Christoph Hellwig
2016-11-05 0:09 ` [PATCH 15/16] xfs: check return value of _trans_reserve_quota_nblks Darrick J. Wong
2016-11-15 10:21 ` Christoph Hellwig
2016-11-05 0:09 ` [PATCH 16/16] xfs: check minimum block size for CRC filesystems Darrick J. Wong
2016-11-15 10:22 ` Christoph Hellwig
2016-11-22 18:26 ` [PATCH 17/16] libxfs-apply: port to stgit Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115101915.GJ1607@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).