From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH RFC 3/4] xfs: reuse xfs_file_iomap_begin_delay() for cow fork delalloc
Date: Fri, 18 Nov 2016 00:13:02 -0800 [thread overview]
Message-ID: <20161118081302.GB9788@infradead.org> (raw)
In-Reply-To: <20161115181125.GE65218@bfoster.bfoster>
On Tue, Nov 15, 2016 at 01:11:25PM -0500, Brian Foster wrote:
> On Tue, Nov 15, 2016 at 06:28:26AM -0800, Christoph Hellwig wrote:
> > > + /*
> > > + * Search for a preexisting extent. COW fork allocation may still be
> > > + * required for reflink inodes if the data extent is shared.
> > > + */
> > > xfs_bmap_search_extents(ip, offset_fsb, XFS_DATA_FORK, &eof, &idx,
> > > &got, &prev);
> > > imap = got;
> >
> > Maybe we should look up directly into imap and now duplicate that
> > information for imap and got?
> >
>
> Didn't you recently change this code from doing that? I'm not following
> how changing it back helps us...
You only introduce imap in the previous patch. I'd just try to avoid
copying the irec structures as much as possible.
next prev parent reply other threads:[~2016-11-18 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 20:27 [PATCH RFC 0/4] xfs: basic cow fork speculative preallocation Brian Foster
2016-11-08 20:27 ` [PATCH RFC 1/4] xfs: clean up cow fork reservation and tag inodes correctly Brian Foster
2016-11-15 14:16 ` Christoph Hellwig
2016-11-15 18:11 ` Brian Foster
2016-11-18 8:11 ` Christoph Hellwig
2016-11-18 15:10 ` Brian Foster
2016-11-08 20:27 ` [PATCH RFC 2/4] xfs: logically separate iomap range from allocation range Brian Foster
2016-11-15 14:18 ` Christoph Hellwig
2016-11-15 18:11 ` Brian Foster
2016-11-08 20:27 ` [PATCH RFC 3/4] xfs: reuse xfs_file_iomap_begin_delay() for cow fork delalloc Brian Foster
2016-11-15 14:28 ` Christoph Hellwig
2016-11-15 18:11 ` Brian Foster
2016-11-18 8:13 ` Christoph Hellwig [this message]
2016-11-18 15:11 ` Brian Foster
2016-11-08 20:27 ` [PATCH RFC 4/4] xfs: implement basic COW fork speculative preallocation Brian Foster
2016-11-08 20:48 ` [PATCH RFC 0/4] xfs: basic cow " Darrick J. Wong
2016-11-08 22:39 ` Brian Foster
2016-11-08 23:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118081302.GB9788@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).