From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: david@fromorbit.com, eguan@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 1/3] generic/182: retain existing btrfs behavior when len == 0
Date: Wed, 23 Nov 2016 17:51:15 -0800 [thread overview]
Message-ID: <20161124015115.GB30324@birch.djwong.org> (raw)
In-Reply-To: <147986705412.27133.3961713804630246198.stgit@birch.djwong.org>
Since btrfs has always interpreted src_length=0 as "return 0 having
taken no action", test for that instead.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/generic/182 | 6 +++---
tests/generic/182.out | 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/tests/generic/182 b/tests/generic/182
index f484399..7fafec0 100755
--- a/tests/generic/182
+++ b/tests/generic/182
@@ -1,10 +1,10 @@
#! /bin/bash
# FS QA Test No. 182
#
-# Test the convention that dedupe with length == 0 means "to the end of fileA"
+# Test the convention that dedupe with length == 0 always returns success.
# - Create a file.
-# - Try to dedupe "zero" bytes (which means dedupe to EOF).
-# - Check that the dedupe happened.
+# - Try to dedupe "zero" bytes.
+# - Check that the dedupe happened and nothing changed.
#
#-----------------------------------------------------------------------
# Copyright (c) 2015, Oracle and/or its affiliates. All Rights Reserved.
diff --git a/tests/generic/182.out b/tests/generic/182.out
index 049a3ee..9841b76 100644
--- a/tests/generic/182.out
+++ b/tests/generic/182.out
@@ -1,12 +1,10 @@
QA output created by 182
Create the original files
-dedupe: Extents did not match.
f4820540fc0ac02750739896fe028d56 TEST_DIR/test-182/file1
69ad53078a16243d98e21d9f8704a071 TEST_DIR/test-182/file2
69ad53078a16243d98e21d9f8704a071 TEST_DIR/test-182/file2.chk
Compare against check files
Make the original file almost dedup-able
-dedupe: Extents did not match.
f4820540fc0ac02750739896fe028d56 TEST_DIR/test-182/file1
158d4e3578b94b89cbb44493a2110fb9 TEST_DIR/test-182/file2
158d4e3578b94b89cbb44493a2110fb9 TEST_DIR/test-182/file2.chk
prev parent reply other threads:[~2016-11-24 1:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 2:10 [PATCH 1/3] generic/182: retain existing btrfs behavior when len == 0 Darrick J. Wong
2016-11-23 2:11 ` [PATCH 2/3] misc: fix some minor problems testing ocfs2 Darrick J. Wong
2016-11-23 9:59 ` Eryu Guan
2016-11-23 2:11 ` [PATCH 3/3] ocfs2: test reflinking to inline data files Darrick J. Wong
2016-11-23 16:34 ` Eryu Guan
2016-11-23 19:27 ` Darrick J. Wong
2016-11-24 1:53 ` [PATCH v2 " Darrick J. Wong
2016-11-24 9:01 ` Eryu Guan
2016-11-28 17:22 ` Darrick J. Wong
2016-11-23 10:33 ` [PATCH 1/3] generic/182: retain existing btrfs behavior when len == 0 Eryu Guan
2016-11-23 19:13 ` Darrick J. Wong
2016-11-24 1:51 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124015115.GB30324@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).