From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout02.posteo.de ([185.67.36.66]:40299 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbcLAAVU (ORCPT ); Wed, 30 Nov 2016 19:21:20 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 9FAF420AC1 for ; Thu, 1 Dec 2016 01:21:15 +0100 (CET) Date: Wed, 30 Nov 2016 19:20:50 -0500 From: Felix Janda Subject: Re: [PATCH v2] Fix building xfsprogs on 32-bit platforms Message-ID: <20161201001952.GA1318@nyan> References: <1480549580-105022-1-git-send-email-ebiggers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480549580-105022-1-git-send-email-ebiggers@google.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Biggers Cc: linux-xfs@vger.kernel.org, Dave Chinner Eric Biggers wrote: > xfslibs now requires that its users enable transparent largefile > support. This broke building xfsprogs on 32-bit Linux (with glibc) > because _FILE_OFFSET_BITS=64 was not getting defined. Although the > autoconf macro AC_SYS_LARGEFILE was intended to define it, this didn't > work because AC_SYS_LARGEFILE will only define _FILE_OFFSET_BITS in a > config header, which doesn't work for xfsprogs because not all .c files > include platform_defs.h as their first include. Also, > platform_defs.h.in is not generated by autoheader and didn't contain a > template for _FILE_OFFSET_BITS. > > Therefore, to fix the problem remove the useless autoconf macros and > instead add -D_FILE_OFFSET_BITS=64 to CFLAGS in builddefs.in. Use > CFLAGS rather than PCFLAGS because this definition could be needed by > platforms other than "linux", and it doesn't hurt to always define it. Sorry, for this breakage. Patch looks good to me except that also the now unecessary definition of AC_NEED_LFS should be removed from m4/package_libcdev.m4. Removing AC_SYS_LARGEFILE also has the advantage that the configure script does no longer have a --disable-largefile option. Felix