From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] xfs: set AGI buffer type in xlog_recover_clear_agi_bucket
Date: Thu, 1 Dec 2016 07:15:44 -0500 [thread overview]
Message-ID: <20161201121543.GB22890@bfoster.bfoster> (raw)
In-Reply-To: <4a62db7d-d3aa-9ad7-4b28-87964f312e15@sandeen.net>
On Wed, Nov 30, 2016 at 04:40:18PM -0600, Eric Sandeen wrote:
> xlog_recover_clear_agi_bucket didn't set the
> type to XFS_BLFT_AGI_BUF, so we got a warning during log
> replay (or an ASSERT on a debug build).
>
> XFS (md0): Unknown buffer type 0!
> XFS (md0): _xfs_buf_ioapply: no ops on block 0xaea8802/0x1
>
> Fix this, as was done in f19b872b for 2 other locations
> with the same problem.
>
> cc: <stable@vger.kernel.org> # 3.10 to current
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
> index 9b3d7c7..2d91f5a 100644
> --- a/fs/xfs/xfs_log_recover.c
> +++ b/fs/xfs/xfs_log_recover.c
> @@ -4929,6 +4929,7 @@ static inline bool xlog_item_is_intent(struct xfs_log_item *lip)
> agi->agi_unlinked[bucket] = cpu_to_be32(NULLAGINO);
> offset = offsetof(xfs_agi_t, agi_unlinked) +
> (sizeof(xfs_agino_t) * bucket);
> + xfs_trans_buf_set_type(tp, agibp, XFS_BLFT_AGI_BUF);
> xfs_trans_log_buf(tp, agibp, offset,
> (offset + sizeof(xfs_agino_t) - 1));
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-01 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 22:36 [PATCH 0/2] xfs: AGI buffer type handling Eric Sandeen
2016-11-30 22:40 ` [PATCH 1/2] xfs: set AGI buffer type in xlog_recover_clear_agi_bucket Eric Sandeen
2016-12-01 12:15 ` Brian Foster [this message]
2016-12-02 13:15 ` Christoph Hellwig
2016-11-30 22:42 ` [PATCH 2/2] xfs: Move AGI buffer type setting to xfs_read_agi Eric Sandeen
2016-12-01 12:15 ` Brian Foster
2016-12-01 17:43 ` [PATCH 2/2 V2] " Eric Sandeen
2016-12-02 13:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201121543.GB22890@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox