From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: deprecate barrier/nobarrier mount option
Date: Thu, 1 Dec 2016 16:31:08 -0500 [thread overview]
Message-ID: <20161201213107.GA59700@bfoster.bfoster> (raw)
In-Reply-To: <20161201202006.GG11750@dastard>
On Fri, Dec 02, 2016 at 07:20:06AM +1100, Dave Chinner wrote:
> On Thu, Dec 01, 2016 at 07:47:46AM -0500, Brian Foster wrote:
> > On Thu, Dec 01, 2016 at 09:54:44AM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > We always perform integrity operations now, so these mount options
> > > don't do anything. Deprecate them and mark them for removal in
> > > in a year.
> > >
> > > Signed-Off-By: Dave Chinner <dchinner@redhat.com>
> > > ---
> > > Documentation/filesystems/xfs.txt | 12 ++++--------
> > > fs/xfs/xfs_super.c | 25 ++++++++++++++++---------
> > > 2 files changed, 20 insertions(+), 17 deletions(-)
> > >
> > ...
> > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > > index 563d1d146b8c..eecbaac08eba 100644
> > > --- a/fs/xfs/xfs_super.c
> > > +++ b/fs/xfs/xfs_super.c
> > ...
> > > @@ -374,6 +371,14 @@ xfs_parseargs(
> > > mp->m_flags |= XFS_MOUNT_DAX;
> > > break;
> > > #endif
> > > + case Opt_barrier:
> > > + xfs_warn(mp, "%s option is deprecated, ignoring.", p);
> > > + mp->m_flags |= XFS_MOUNT_BARRIER;
> > > + break;
> > > + case Opt_nobarrier:
> > > + xfs_warn(mp, "%s option is deprecated, ignoring.", p);
> > > + mp->m_flags &= ~XFS_MOUNT_BARRIER;
> > > + break;
> >
> > So basically XFS_MOUNT_BARRIER exists solely for the purpose of
> > showargs. Should we just kill it too and do something deterministic on
> > showargs (i.e., always show 'barrier' or just drop it entirely), or does
> > precedent suggest otherwise?
>
> Well, they are deprecated and ignored, but we can't remove them
> straight away so I thought we should still report them appropriately
> in showargs.
>
> I don't really care either way - I can kill it completely if
> you think that's better.
>
Ok. No major preference.. my first instinct was just to see it all
killed off to explicitly show that the mount option has no effect.
Either way is fine, thanks.
Brian
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2016-12-01 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 22:54 [RFC PATCH 0/2] xfs: deprecate barrier/nobarrier Dave Chinner
2016-11-30 22:54 ` [PATCH 1/2] xfs: Always flush caches when integrity is required Dave Chinner
2016-12-01 12:47 ` Brian Foster
2016-12-05 16:22 ` Christoph Hellwig
2016-11-30 22:54 ` [PATCH 2/2] xfs: deprecate barrier/nobarrier mount option Dave Chinner
2016-12-01 9:54 ` Jan Kara
2016-12-01 9:59 ` Christoph Hellwig
2016-12-01 12:47 ` Brian Foster
2016-12-01 20:20 ` Dave Chinner
2016-12-01 21:31 ` Brian Foster [this message]
2016-12-05 16:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201213107.GA59700@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).