From: Dave Chinner <david@fromorbit.com>
To: Lucas Stach <dev@lynxeye.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/2] XFS buffer cache scalability improvements
Date: Mon, 5 Dec 2016 08:36:45 +1100 [thread overview]
Message-ID: <20161204213645.GK11750@dastard> (raw)
In-Reply-To: <1480715692.6684.1.camel@lynxeye.de>
On Fri, Dec 02, 2016 at 10:54:52PM +0100, Lucas Stach wrote:
.....
> > So with the rhashtable change in place, we've already removed the
> > cause of the pag_buf_lock contention (the rbtree pointer chasing) so
> > there just isn't any overhead that using RCU can optimise away.
> > Hence there's no gains to amortise the efficiency losses using RCU
> > freeing introduces, and as a result using RCU is slower than
> > traditional locking techniques.
> >
> > I'll keep testing the rhashtbale code - it look solid enough at this
> > point to consider it for the 4.10 cycle.
> >
> Thanks for running those numbers. I had started to modify the patches
> according to the review, but didn't get around to fix the RCU path.
>
> Do you still consider this change to go in with 4.10?
Yes, I posted an up-to-date version of it in this series I posted
last friday:
https://www.spinics.net/lists/linux-xfs/msg02532.html
https://www.spinics.net/lists/linux-xfs/msg02535.html
Needs review before I'll merge it for 4.10, though.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2016-12-04 21:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 20:14 [PATCH 0/2] XFS buffer cache scalability improvements Lucas Stach
2016-10-18 20:14 ` [PATCH 1/2] xfs: use rhashtable to track buffer cache Lucas Stach
2016-10-18 22:18 ` Dave Chinner
2016-10-22 18:01 ` Lucas Stach
2016-10-24 2:15 ` Dave Chinner
2016-10-24 11:47 ` Lucas Stach
2016-10-19 1:15 ` Dave Chinner
2016-10-18 20:14 ` [PATCH 2/2] xfs: switch buffer cache entries to RCU freeing Lucas Stach
2016-10-18 22:43 ` Dave Chinner
2016-10-22 18:52 ` Lucas Stach
2016-10-24 2:37 ` Dave Chinner
2016-10-18 21:21 ` [PATCH 0/2] XFS buffer cache scalability improvements Dave Chinner
2016-10-22 17:51 ` Lucas Stach
2016-11-10 23:02 ` Dave Chinner
2016-12-02 21:54 ` Lucas Stach
2016-12-04 21:36 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161204213645.GK11750@dastard \
--to=david@fromorbit.com \
--cc=dev@lynxeye.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox