From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: make xfs btree stats less huge
Date: Mon, 5 Dec 2016 12:14:32 +1100 [thread overview]
Message-ID: <20161205011432.GP31101@dastard> (raw)
In-Reply-To: <20161202132044.GC426@infradead.org>
On Fri, Dec 02, 2016 at 05:20:44AM -0800, Christoph Hellwig wrote:
>
> > --- a/fs/xfs/xfs_stats.h
> > +++ b/fs/xfs/xfs_stats.h
> > @@ -21,10 +21,30 @@
> >
> > #include <linux/percpu.h>
> >
> > +enum {
> > + __XBTS_lookup = 0,
>
> Add a comment on top of the enum to explain these are the
> offsets into each btree type?
Will do.
> > +#define XFS_STATS_CALC_INDEX(member) \
> > + (offsetof(struct __xfsstats, member) / (int)sizeof(__uint32_t))
>
> what's that int cast for?
Habit - prevents 64 bit division on 32 bit systems. But given this
is evaluated at compile time, that doesn't matter. Will remove.
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-12-05 1:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 10:30 [PATCH 0/3] xfs: miscellaneous improvements for 4.10 Dave Chinner
2016-12-01 10:30 ` [PATCH 1/3] xfs: make xfs btree stats less huge Dave Chinner
2016-12-02 13:20 ` Christoph Hellwig
2016-12-05 1:14 ` Dave Chinner [this message]
2016-12-05 12:48 ` Christoph Hellwig
2016-12-01 10:30 ` [PATCH 2/3] xfs: use rhashtable to track buffer cache Dave Chinner
2016-12-05 17:04 ` Christoph Hellwig
2016-12-07 6:32 ` Dave Chinner
2016-12-01 10:30 ` [PATCH 3/3] xfs: optimise CRC updates Dave Chinner
2016-12-02 13:22 ` Christoph Hellwig
2016-12-04 22:12 ` Dave Chinner
2016-12-05 12:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205011432.GP31101@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).