public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [BUG] xfs/109 crashed 2k block size reflink enabled XFS
Date: Tue, 6 Dec 2016 23:24:09 +0800	[thread overview]
Message-ID: <20161206152409.GY29149@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20161206134847.GA10181@infradead.org>

On Tue, Dec 06, 2016 at 05:48:47AM -0800, Christoph Hellwig wrote:
> Hi Eryu,
> 
> my attempts at reproducing this are still not very reliable, someimes
> it takes three iterations, sometimes it's doing fine for 100+.
> 
> Can you try reverting commit 0af32fb46 ("xfs: fix bogus space
> reservation in xfs_iomap_write_allocate") and give this a spin on your
> test setup?  I wonder if somehow our accounting for the case where

Sure, test is running now.

Looking at this commit, reminds me another bug I reported in Aug. that I
wasn't able to find a simpler reproducer..

https://www.spinics.net/lists/xfs/msg42159.html

Thanks,
Eryu

> we convert from inline extents to the btree format is not correct,
> and the code before that commit was papering over that fact.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-12-06 15:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05  9:21 [BUG] xfs/109 crashed 2k block size reflink enabled XFS Eryu Guan
2016-12-05 12:45 ` Christoph Hellwig
2016-12-05 14:39 ` Christoph Hellwig
2016-12-05 15:36   ` Christoph Hellwig
2016-12-05 18:28     ` Darrick J. Wong
2016-12-05 19:05       ` Christoph Hellwig
2016-12-06  6:37       ` Eryu Guan
2016-12-06 14:45       ` Christoph Hellwig
2016-12-06 15:19         ` Brian Foster
2016-12-06 18:14           ` Darrick J. Wong
2016-12-07  3:49         ` Darrick J. Wong
2016-12-07  7:18           ` Christoph Hellwig
2016-12-07 17:40             ` Christoph Hellwig
2016-12-08  6:35               ` Darrick J. Wong
2016-12-08 14:30                 ` Christoph Hellwig
2016-12-06 13:48 ` Christoph Hellwig
2016-12-06 15:24   ` Eryu Guan [this message]
2016-12-06 16:31     ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206152409.GY29149@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox