From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_logprint: di_gen is unsigned
Date: Wed, 7 Dec 2016 14:02:01 -0500 [thread overview]
Message-ID: <20161207190201.GD23106@bfoster.bfoster> (raw)
In-Reply-To: <c453839b-61db-9500-b39d-e6580d1748b5@redhat.com>
On Mon, Dec 05, 2016 at 04:48:01PM -0600, Eric Sandeen wrote:
> di_gen is unsigned:
>
> __uint32_t di_gen; /* generation number */
>
> but we print it as a signed int in logprint, so see oddities like:
>
> forkoff:24 dmevmask:0x0 dmstate:0 flags:0x0 gen:-628807103
>
> Fix this.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/logprint/log_print_all.c b/logprint/log_print_all.c
> index f49316e..3863ba9 100644
> --- a/logprint/log_print_all.c
> +++ b/logprint/log_print_all.c
> @@ -269,7 +269,7 @@ xlog_recover_print_inode_core(
> di->di_size, (unsigned long long)di->di_nblocks,
> di->di_extsize, di->di_nextents, (int)di->di_anextents);
> printf(_(" forkoff:%d dmevmask:0x%x dmstate:%d flags:0x%x "
> - "gen:%d\n"),
> + "gen:%u\n"),
> (int)di->di_forkoff, di->di_dmevmask, (int)di->di_dmstate,
> (int)di->di_flags, di->di_gen);
> if (di->di_version == 3) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-12-07 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 22:48 [PATCH] xfs_logprint: di_gen is unsigned Eric Sandeen
2016-12-07 19:02 ` Brian Foster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207190201.GD23106@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).