From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC] Preparing for XFS reflink D-day
Date: Mon, 12 Dec 2016 13:45:44 +1100 [thread overview]
Message-ID: <20161212024544.GU4326@dastard> (raw)
In-Reply-To: <CAOQ4uxiCTrTsBSzUp9wOs-1FmBiF4kkDCzzeaonciA-NJHWR0A@mail.gmail.com>
On Sun, Dec 11, 2016 at 09:23:38PM +0200, Amir Goldstein wrote:
> > Un-sharing an fs full of reflinked files requires us to build code to
> > iterate every bmbt of every file (or to cross-reference every refcountbt
> > record against the rmapbt to find the sharers) and then relocate the
> > data, which is quite a bit more complex... and unnecessary since we can
> > rebuild all the broken refcount metadata anyway.
>
> You are right, of course, from technical POV, but psychologically, if people
> know they have a safe way back to what they know and trust, it is easier
> for them make the leap...
/me shakes his head.
If people don't feel safe running experimental code that might go
wrong, they're going to be absolutely thrilled to hear that when it
does go wrong, there's even more experimental code that will try to
fix it up again.
No.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-12-12 2:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 8:04 [RFC] Preparing for XFS reflink D-day Amir Goldstein
2016-12-10 19:42 ` Darrick J. Wong
2016-12-11 8:38 ` Amir Goldstein
2016-12-11 18:27 ` Darrick J. Wong
2016-12-11 19:23 ` Amir Goldstein
2016-12-12 2:45 ` Dave Chinner [this message]
2016-12-12 1:59 ` Dave Chinner
2016-12-12 5:06 ` Amir Goldstein
2016-12-12 7:44 ` Dave Chinner
2016-12-12 8:10 ` Amir Goldstein
2016-12-13 0:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212024544.GU4326@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox