From: Anna Schumaker <Anna.Schumaker@Netapp.com>
To: linux-xfs@vger.kernel.org
Cc: david@fromorbit.com
Subject: [PATCH v2] xfs_io: Improvements to copy_range return code handling
Date: Wed, 14 Dec 2016 16:28:46 -0500 [thread overview]
Message-ID: <20161214212846.22198-1-Anna.Schumaker@Netapp.com> (raw)
If copy_file_range() returns 0, then that means no data was copied. We
should break out of the loop in this case to prevent looping
indefinitely.
Additionally, if an error is returned by copy_file_range() then we need
to print out the string form to be used by error checking tests in
xfstests.
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---
v2:
- Use perror() instead of fprintf()
---
io/copy_file_range.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/io/copy_file_range.c b/io/copy_file_range.c
index 88203e9..249c649 100644
--- a/io/copy_file_range.c
+++ b/io/copy_file_range.c
@@ -49,8 +49,11 @@ copy_file_range(int fd, loff_t *src, loff_t *dst, size_t len)
do {
ret = syscall(__NR_copy_file_range, fd, src, file->fd, dst, len, 0);
- if (ret == -1)
+ if (ret == -1) {
+ perror("copy_range");
return errno;
+ } else if (ret == 0)
+ break;
len -= ret;
} while (len > 0);
--
2.10.2
next reply other threads:[~2016-12-14 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 21:28 Anna Schumaker [this message]
2016-12-15 11:26 ` [PATCH v2] xfs_io: Improvements to copy_range return code handling Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214212846.22198-1-Anna.Schumaker@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).