From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, eguan@redhat.com, darrick.wong@oracle.com
Subject: Re: [PATCH 4/4] xfs: don't rely on ->total in xfs_alloc_space_available
Date: Wed, 14 Dec 2016 16:51:58 -0500 [thread overview]
Message-ID: <20161214215158.GB26688@bfoster.bfoster> (raw)
In-Reply-To: <20161214193802.GB12217@lst.de>
On Wed, Dec 14, 2016 at 08:38:02PM +0100, Christoph Hellwig wrote:
> On Wed, Dec 14, 2016 at 01:30:18PM -0500, Brian Foster wrote:
> > > /* do we have enough contiguous free space for the allocation? */
> > > + alloc_len = args->minlen + (args->alignment - 1)+ args->minalignslop;
> >
> > Whitespace nit, missing space: ^
> >
> > Also, is the addition of braces intentional? I believe it is possible
> > for args->alignment == 0.
>
> It's mostly for explaining the - 1 to the reader as it took me a while
> to figure out what it was for.
Oh, care to elaborate? :)
Brian
next prev parent reply other threads:[~2016-12-14 21:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 15:59 minleft fixes Christoph Hellwig
2016-12-13 15:59 ` [PATCH 1/4] xfs: fix bogus minleft manipulations Christoph Hellwig
2016-12-14 17:35 ` Brian Foster
2016-12-14 19:36 ` Christoph Hellwig
2016-12-14 21:51 ` Brian Foster
[not found] ` <20161215143430.GB29477@bfoster.bfoster>
2016-12-16 8:21 ` Christoph Hellwig
2016-12-19 11:38 ` Christoph Hellwig
2016-12-20 14:17 ` Brian Foster
2016-12-20 21:45 ` Dave Chinner
2016-12-15 22:09 ` Dave Chinner
2016-12-16 8:20 ` Christoph Hellwig
2017-01-04 6:32 ` Darrick J. Wong
2017-01-04 8:50 ` Christoph Hellwig
2016-12-13 15:59 ` [PATCH 2/4] xfs: calculate minleft correctly for bmap allocations Christoph Hellwig
2016-12-14 18:24 ` Brian Foster
2016-12-13 15:59 ` [PATCH 3/4] xfs: adjust allocation length in xfs_alloc_space_available Christoph Hellwig
2016-12-14 18:24 ` Brian Foster
2016-12-14 19:37 ` Christoph Hellwig
2016-12-15 20:41 ` Libor Klepáč
2016-12-16 8:20 ` Christoph Hellwig
2016-12-16 0:28 ` Dave Chinner
2016-12-16 8:25 ` Christoph Hellwig
2016-12-18 23:55 ` Dave Chinner
2016-12-13 15:59 ` [PATCH 4/4] xfs: don't rely on ->total " Christoph Hellwig
2016-12-14 18:30 ` Brian Foster
2016-12-14 19:38 ` Christoph Hellwig
2016-12-14 21:51 ` Brian Foster [this message]
2016-12-15 8:55 ` Christoph Hellwig
2016-12-15 12:00 ` Brian Foster
2016-12-14 10:51 ` minleft fixes Eryu Guan
2016-12-15 10:24 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2017-01-09 19:53 minleft fixes V3 Christoph Hellwig
2017-01-09 19:53 ` [PATCH 4/4] xfs: don't rely on ->total in xfs_alloc_space_available Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214215158.GB26688@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).