From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs_io: prefix dedupe command error messages consistently
Date: Mon, 19 Dec 2016 11:50:20 -0800 [thread overview]
Message-ID: <20161219195020.GA5487@birch.djwong.org> (raw)
Prefix the perror output of the dedupe command consistently. All the
other perror calls reference the ioctl name directly, so we might as
well do that for all the dedupe cases.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
io/reflink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/io/reflink.c b/io/reflink.c
index d4c745c..dde26b8 100644
--- a/io/reflink.c
+++ b/io/reflink.c
@@ -79,12 +79,12 @@ dedupe_ioctl(
goto done;
}
if (info->status < 0) {
- fprintf(stderr, "dedupe: %s\n",
+ fprintf(stderr, "XFS_IOC_FILE_EXTENT_SAME: %s\n",
_(strerror(-info->status)));
goto done;
}
if (info->status == XFS_EXTENT_DATA_DIFFERS) {
- fprintf(stderr, "dedupe: %s\n",
+ fprintf(stderr, "XFS_IOC_FILE_EXTENT_SAME: %s\n",
_("Extents did not match."));
goto done;
}
next reply other threads:[~2016-12-19 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 19:50 Darrick J. Wong [this message]
2016-12-20 0:06 ` [PATCH] xfs_io: prefix dedupe command error messages consistently Eric Sandeen
2016-12-20 20:24 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219195020.GA5487@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).