From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:32997 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756543AbcLUTER (ORCPT ); Wed, 21 Dec 2016 14:04:17 -0500 Received: by mail-pg0-f67.google.com with SMTP id g1so15451949pgn.0 for ; Wed, 21 Dec 2016 11:04:17 -0800 (PST) Date: Wed, 21 Dec 2016 11:04:13 -0800 From: Eric Biggers Subject: Re: [PATCH v3] Fix building xfsprogs on 32-bit platforms Message-ID: <20161221190413.GA136777@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480552932-614-1-git-send-email-ebiggers@google.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: linux-xfs@vger.kernel.org Cc: Dave Chinner , Eric Sandeen , Eric Biggers , Felix Janda > xfslibs now requires that its users enable transparent largefile > support. This broke building xfsprogs on 32-bit Linux (with glibc) > because _FILE_OFFSET_BITS=64 was not getting defined. Although the > autoconf macro AC_SYS_LARGEFILE was intended to define it, this didn't > work because AC_SYS_LARGEFILE will only define _FILE_OFFSET_BITS in a > config header, which doesn't work for xfsprogs because not all .c files > include platform_defs.h as their first include. Also, > platform_defs.h.in is not generated by autoheader and didn't contain a > template for _FILE_OFFSET_BITS. > > Therefore, to fix the problem remove the useless autoconf macros and > instead add -D_FILE_OFFSET_BITS=64 to CFLAGS in builddefs.in. Use > CFLAGS rather than PCFLAGS because this definition could be needed by > platforms other than "linux", and it doesn't hurt to always define it. > > Signed-off-by: Eric Biggers Hi, Is this patch planned to be applied? Building 32-bit Linux binaries of xfsprogs is still broken on the master branch, and there's nothing in for-next. Eric