From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:59184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760568AbdACSYw (ORCPT ); Tue, 3 Jan 2017 13:24:52 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 949A583F46 for ; Tue, 3 Jan 2017 18:24:53 +0000 (UTC) Date: Tue, 3 Jan 2017 13:24:51 -0500 From: Brian Foster Subject: Re: [PATCH] xfsprogs: fix a couple 32-bit build warnings Message-ID: <20170103182451.GA18120@bfoster.bfoster> References: <6d40e289-13ef-26fa-24d6-6b8e052d3a76@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d40e289-13ef-26fa-24d6-6b8e052d3a76@redhat.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs On Thu, Dec 22, 2016 at 09:28:50AM -0600, Eric Sandeen wrote: > on 32-bit builds: > > mremap_f can't turn a long long into a pointer, and > dump_dirent needs proper %llx & a cast for u64 args > as is done elsewhere. > > Signed-off-by: Eric Sandeen > --- Looks Ok to me: Reviewed-by: Brian Foster > > diff --git a/io/mmap.c b/io/mmap.c > index dc188d0..6f1d330 100644 > --- a/io/mmap.c > +++ b/io/mmap.c > @@ -628,8 +628,8 @@ mremap_f( > switch (c) { > case 'f': > flags = MREMAP_FIXED|MREMAP_MAYMOVE; > - new_addr = (void *)cvtnum(blocksize, sectsize, > - optarg); > + new_addr = (void *)(unsigned long)cvtnum(blocksize, > + sectsize, optarg); > break; > case 'm': > flags = MREMAP_MAYMOVE; > diff --git a/io/readdir.c b/io/readdir.c > index 151b72e..b868d1b 100644 > --- a/io/readdir.c > +++ b/io/readdir.c > @@ -71,9 +71,10 @@ dump_dirent( > long long offset, > struct dirent *dirent) > { > - printf("%08llx: d_ino: 0x%08lx", offset, dirent->d_ino); > + printf("%08llx: d_ino: 0x%08llx", offset, > + (unsigned long long)dirent->d_ino); > #ifdef _DIRENT_HAVE_D_OFF > - printf(" d_off: 0x%08lx", dirent->d_off); > + printf(" d_off: 0x%08llx", (unsigned long long)dirent->d_off); > #endif > #ifdef _DIRENT_HAVE_D_RECLEN > printf(" d_reclen: 0x%x", dirent->d_reclen); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html