Re: [PATCH 2/5] xfs: fix the alignment fallback in xfs_bmap_btalloc

[Brian Foster <bfoster@redhat.com>]

On Sun, Jan 08, 2017 at 11:31:34AM +0100, Christoph Hellwig wrote:
> On Wed, Jan 04, 2017 at 09:34:05AM -0500, Brian Foster wrote:
> > Ok, but we have the following near the top of xfs_alloc_vextent():
> > 
> >         if (args->alignment == 0)
> >                 args->alignment = 1;
> > 
> > ... so I'm not sure the commit log description is accurate. That aside:
> > 
> > Reviewed-by: Brian Foster <bfoster@redhat.com>
> 
> Well, in that case we might not actually need it.  This was just a
> a drive-by patch from investigating what the alignmnet - 1 mean in
> the allocator.
> 
> Either way this could be cleaned up, but probably shouldn't be in
> a minimal bugfix series.

We could also just replace it with something like ASSERT(args->alignment
> 0) before the use of (alignment - 1), which is kind of
self-documenting (but still probably not worth a patch on its own). But
fair enough either way...

Brian

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html