From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@redhat.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 6/5] xfs_db: fix the 'source' command when passed as a -c option
Date: Thu, 12 Jan 2017 11:27:53 -0800 [thread overview]
Message-ID: <20170112192753.GX14038@birch.djwong.org> (raw)
In-Reply-To: <148419038856.32674.6479634718673149751.stgit@birch.djwong.org>
The 'source' command is supposed to read commands out of a file and
execute them. This works great when done from an interactive command
line, but it doesn't work at all when invoked from the command line
because we never actually do anything with the opened file.
So don't load stdin into the input stack when we're only executing
command line options, and use that to decide if source_f is executing
from the command line so that we can actually run the input loop. We'll
use this for the per-field fuzzing xfstests.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/init.c | 2 +-
db/input.c | 29 +++++++++++++++++++++++++++--
2 files changed, 28 insertions(+), 3 deletions(-)
diff --git a/db/init.c b/db/init.c
index db133d7..729ce66 100644
--- a/db/init.c
+++ b/db/init.c
@@ -269,7 +269,6 @@ main(
char **v;
int start_iocur_sp;
- pushfile(stdin);
init(argc, argv);
start_iocur_sp = iocur_sp;
@@ -284,6 +283,7 @@ main(
goto close_devices;
}
+ pushfile(stdin);
while (!done) {
if ((input = fetchline()) == NULL)
break;
diff --git a/db/input.c b/db/input.c
index 8f65190..3255f27 100644
--- a/db/input.c
+++ b/db/input.c
@@ -145,6 +145,12 @@ get_prompt(void)
return prompt;
}
+static bool
+interactive_input(void)
+{
+ return inputstacksize == 1 && inputstack[0] == stdin;
+}
+
static char *
fetchline_internal(void)
{
@@ -156,13 +162,15 @@ fetchline_internal(void)
rval = NULL;
for (rlen = iscont = 0; ; ) {
- if (inputstacksize == 1) {
+ if (interactive_input()) {
if (iscont)
dbprintf("... ");
else
dbprintf(get_prompt(), progname);
fflush(stdin);
}
+ if (curinput == NULL)
+ return NULL;
if (seenint() ||
(!fgets(buf, sizeof(buf), curinput) &&
ferror(curinput) && seenint())) {
@@ -183,7 +191,8 @@ fetchline_internal(void)
(len = strlen(buf)) == 0) {
popfile();
if (curinput == NULL) {
- dbprintf("\n");
+ if (interactive_input())
+ dbprintf("\n");
return NULL;
}
iscont = 0;
@@ -314,12 +323,28 @@ source_f(
char **argv)
{
FILE *f;
+ int c, done = 0;
+ char *input;
+ char **v;
f = fopen(argv[1], "r");
if (f == NULL)
dbprintf(_("can't open %s\n"), argv[0]);
else
pushfile(f);
+
+ /* If this isn't an interactive shell, run the commands now. */
+ if (inputstacksize == 0 || inputstack[0] == stdin)
+ return 0;
+ while (!done) {
+ if ((input = fetchline_internal()) == NULL)
+ break;
+ v = breakline(input, &c);
+ if (c)
+ done = command(c, v);
+ doneline(input, v);
+ }
+
return 0;
}
next prev parent reply other threads:[~2017-01-12 19:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 3:06 [PATCH 0/5] xfsprogs: misc fixes Darrick J. Wong
2017-01-12 3:06 ` [PATCH 1/5] xfs_io: fix the minimum arguments to the reflink command Darrick J. Wong
2017-01-12 13:53 ` Christoph Hellwig
2017-01-12 3:06 ` [PATCH 2/5] xfs_io: fix some documentation problems Darrick J. Wong
2017-01-12 13:53 ` Christoph Hellwig
2017-01-12 3:06 ` [PATCH 3/5] xfs_io: prefix dedupe command error messages consistently Darrick J. Wong
2017-01-12 13:53 ` Christoph Hellwig
2017-01-12 3:06 ` [PATCH 4/5] xfs_db: sanitize geometry on load Darrick J. Wong
2017-01-12 14:34 ` Eric Sandeen
2017-01-12 15:09 ` Brian Foster
2017-01-12 20:41 ` Darrick J. Wong
2017-01-12 20:41 ` [PATCH v2 " Darrick J. Wong
2017-01-12 23:20 ` Eric Sandeen
2017-01-13 0:23 ` Darrick J. Wong
2017-01-13 0:32 ` [PATCH v3 " Darrick J. Wong
2017-01-13 13:35 ` Brian Foster
2017-01-14 2:25 ` Eric Sandeen
2017-01-14 3:44 ` Brian Foster
2017-01-14 3:51 ` Eric Sandeen
2017-01-14 12:53 ` Brian Foster
2017-01-14 14:59 ` Eric Sandeen
2017-01-15 14:10 ` Brian Foster
2017-01-12 3:06 ` [PATCH 5/5] xfs_repair: strengthen geometry checks Darrick J. Wong
2017-01-14 2:13 ` Eric Sandeen
2017-01-20 20:06 ` Darrick J. Wong
2017-01-12 19:27 ` Darrick J. Wong [this message]
2017-01-12 19:34 ` [PATCH 7/5] xfs_repair.8: document dirty log conditions Darrick J. Wong
2017-01-12 19:41 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112192753.GX14038@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).