From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>,
Brian Foster <bfoster@redhat.com>,
Amir Goldstein <amir73il@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: fix xfs_mode_to_ftype() prototype
Date: Wed, 18 Jan 2017 12:55:12 -0800 [thread overview]
Message-ID: <20170118205512.GA12985@birch.djwong.org> (raw)
In-Reply-To: <20170118151353.1544332-1-arnd@arndb.de>
On Wed, Jan 18, 2017 at 04:12:58PM +0100, Arnd Bergmann wrote:
> A harmless warning just got introduced:
>
> fs/xfs/libxfs/xfs_dir2.h:40:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> Removing the 'const' modifier avoids the warning and has no
> other effect.
>
> Fixes: 1fc4d33fed12 ("xfs: replace xfs_mode_to_ftype table with switch statement")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
--D
> ---
> fs/xfs/libxfs/xfs_dir2.c | 2 +-
> fs/xfs/libxfs/xfs_dir2.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
> index eb64f3884d3d..2f389d366e93 100644
> --- a/fs/xfs/libxfs/xfs_dir2.c
> +++ b/fs/xfs/libxfs/xfs_dir2.c
> @@ -38,7 +38,7 @@ struct xfs_name xfs_name_dotdot = { (unsigned char *)"..", 2, XFS_DIR3_FT_DIR };
> /*
> * Convert inode mode to directory entry filetype
> */
> -const unsigned char xfs_mode_to_ftype(int mode)
> +unsigned char xfs_mode_to_ftype(int mode)
> {
> switch (mode & S_IFMT) {
> case S_IFREG:
> diff --git a/fs/xfs/libxfs/xfs_dir2.h b/fs/xfs/libxfs/xfs_dir2.h
> index d4b77ab37a98..d6e6d9d16f6c 100644
> --- a/fs/xfs/libxfs/xfs_dir2.h
> +++ b/fs/xfs/libxfs/xfs_dir2.h
> @@ -37,7 +37,7 @@ extern struct xfs_name xfs_name_dotdot;
> /*
> * Convert inode mode to directory entry filetype
> */
> -extern const unsigned char xfs_mode_to_ftype(int mode);
> +extern unsigned char xfs_mode_to_ftype(int mode);
>
> /*
> * directory operations vector for encode/decode routines
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-01-18 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 15:12 [PATCH] xfs: fix xfs_mode_to_ftype() prototype Arnd Bergmann
2017-01-18 16:50 ` Christoph Hellwig
2017-01-18 20:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118205512.GA12985@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=arnd@arndb.de \
--cc=bfoster@redhat.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).